Albion TwoHanded And Pole DamageCalculation Fix

[Tolakram]

So 2H vs Pole armsman?

There should be very little difference, correct?

[Graveen]

For Albion, on same resists (pole is thrust iirc, 2h is either slash or crush irc), at same spec, yes.

[Overdriven]

There SHOULDN'T be any differences, but currently Two-Handed is out-damaging Polearm from tests I've done in game (Can't test live atm, as patcher is being gimped) and I have no idea why. Damage should be a little less than Pole, but not by much (Pole is the highest damage weapon in game iirc, along with the class being the highest DPs class)

Anyone need any ingame (non-live atm) testing? I can test specs etc, any special ways you want me to test etc?

[Graveen]

iirc pole is the highest due to the GR of the styles in its line, but i think at equivalent spec with equivalent GRs it should be strictly equal.

[Tolakram]

From the Herald today:

http://www.camelotherald.com/news/news_ ... oryid=3935

Does 50 Axe 50 LeftAxe(rr5) do more or better damage with LeftAxe styles than 36(+15, rr5)Axe 50LeftAxe?

It will do the same damage when using LA styles. The same rules are in place with LA, CD, DW, 2H and Polearm.

This confirms what I believed to be true, in that your two handed spec determines how much damage is done via styling and your base spec has no influence whatsoever.

[Kakuri]

This doesn't say the base spec has no effect. The answer given indicates two things:
- spec bonuses are included in the calculations (so 30+5 is better than 30+1)
- there's a cap at 51, which is why 36+15 is just as good as 50+15

[Tolakram]

Hmmmm,

good point. I still believe what I say to be true as a one time member of the Faithful Paladins The common two handed spec was full 2H until the extra points past 40. Variance on damage was only an issue when you did not use a Two Handed style.

The Patch

Code: Select all

             InventoryItem armor = null;
             if (ad.Target.Inventory != null)
                armor = ad.Target.Inventory.GetItem((eInventorySlot)ad.ArmorHitLocation);
+            int lowerboundary = 0;
 
-            int lowerboundary = (WeaponSpecLevel(weapon) - 1) * 50 / (ad.Target.EffectiveLevel + 1) + 75;
+            InventoryItem weapon2 = weapon;
+            if ((weapon.Object_Type == (int)eObjectType.TwoHandedWeapon) || (weapon.Object_Type == (int)eObjectType.PolearmWeapon)) //albion polearm and two-handed weapons
+            {
+               if (weapon.Type_Damage == (int)eDamageType.Crush)//Crush damage means it is based off Crush spec
+               {
+                  weapon2.Object_Type = (int)eObjectType.CrushingWeapon;
+               }
+               else if (weapon.Type_Damage == (int)eDamageType.Slash)//Slash damage means it is based off Slash spec
+               {
+                  weapon2.Object_Type = (int)eObjectType.SlashingWeapon;
+               }
+               else //Thrust damage means it is based off Thrust spec
+               {
+                  weapon2.Object_Type = (int)eObjectType.ThrustWeapon;
+               }
+            }
+            lowerboundary = (WeaponSpecLevel(weapon2) - 1) * 50 / (ad.Target.EffectiveLevel + 1) + 75;
+            
             lowerboundary = Math.Max(lowerboundary, 75);
             lowerboundary = Math.Min(lowerboundary, 125);
             damage *= (GetWeaponSkill(weapon) + 90.68) / (ad.Target.GetArmorAF(ad.ArmorHitLocation) + 20 * 4.67);


Will adjust the variance regardless of style used. Instead I think this needs to check to see if the player is styling. If true then use the spec of the style to determine the variance of the damage.

The bug in DOL is that players do not have to spec base skill in order to reduce unstyled variance. With endurance that way it is today I don;t see this being much of an issue. They certainly aren't doing too much damage as it stands now!

[Tolakram]

Actually that's a bit wrong as well.

This is what I can find on the subject:

Two-Hand spec effects what styles you get AND the MAXIMUM damage variance.

Weapon Spec (Slash, Thrust, Crush) gives you styles that you will never use, and effects MINIMUM damage variance.

A discussion when everyone thought double speccing was going to be removed:

http://forums.drunkenfriar.com/viewtopi ... &sk=t&sd=a

[Dunnerholl]

From the Herald today:

http://www.camelotherald.com/news/news_ ... oryid=3935

Does 50 Axe 50 LeftAxe(rr5) do more or better damage with LeftAxe styles than 36(+15, rr5)Axe 50LeftAxe?

It will do the same damage when using LA styles. The same rules are in place with LA, CD, DW, 2H and Polearm.

This confirms what I believed to be true, in that your two handed spec determines how much damage is done via styling and your base spec has no influence whatsoever.

where does the unstyled damage part of the damage come from then?

[Sand]

I would say calcs for 2hand and pole should should be the same it only differs on styles and I belive pole tends to be preferred due to higher gr. One other factor though is that arms may have a higher proficiency for pole than 2hand but I doubt that. Some classes do have that, main one I know of is Valks, and classes also do better damage with weapons they get by default than ones gained only through cl ablity.

The other factor would be the damage type available which differs between pole and 2hand but those tend to average each other out overall.

Palys will use 2hand because they don't have access to pole.

Edit: I think mythic's grab bag there is fairly misleading. You have to realize that in that example that like Kakuri mentioned that in both situations they have 50 base weapon spec so varience will be same in both.

[Charz]

Bump on this, was this ever put in SVN?

[Tolakram]

Nope.

[Tolakram]

bump .. I really need to look at this and get a fix in.

2 steps. First step is to cap skill bonus at 51, second is to correctly set unstyled variance of two handed or polearm weapons to be calculated from the base spec.

Anyone know if the cap at 51 also applies to casters?

[boltman]

From everything I've read, casters over 50 composite gain .5% damage gain per point over 50. I'm on a pda atm, so cannot quote sources, but i'll post them when I get home.

[boltman]

"every level over 50 you go in composite increases your damage by .5%"
http://www.femmefataledaoc.com/Necroman ... og2006.pdf

also, if you just change the spec level on this calculator, it'll show that .5% increase as well
http://mortal.peril.org/jack/daoc/dmgcalc.html

and I know it's VN, but still some good info here...
http://vnboards.ign.com/albion_elementa ... 554419/p1/

hope it helps