[Accepted] Shield Swipe !.!

[Yemla]

sounds like MoBlocking 5 and MoPain 5 sounds like fun..so basicly ML5 offensive proc would be very sexii to use in this case on a lurikeen hero xo? def. def. checking this on pendragon by pulling massive greens just to test it, like 30greens/blues and check if it hit all, if it did then imma be a believer xP hehe

[Crazys]

Luri/kobis/
15 dex on creation 10 str (for dmaamge on mainhand


But actually
Mob5 + Moparry = no dammage intake
+10% pve block

[Crazys]

What is the Status of This?

Is Shield Swipe / Savage Muti Hit working properly in the DoL Core?

Thanks,
Crazys

[Tired]

Negative....

[Yemla]

Bump!!!

most i've had was about 200ish on live...

Shield hits target
weapon hits all others with standswing
which is why Omnis swords from dragons or crafted are awsome for the LT/endo heal
or DF diamond hammers for the AE dd proc off the weapon
Its amazing... Lets do this... You have 101 mobs on you. You swing and hit target with shield. so thats 100 mainhand swings... you hit 80 with your wep that has a 5% proc rate thats 4 ae procs
So your 70-125 dammge per mob from swing +
4x 75-100 proc damamge
you just did 400-500 damage per mob per swing!

Code: Select all

switch (ad.AttackResult)
            {
                case eAttackResult.Blocked:
                case eAttackResult.Fumbled:
                case eAttackResult.HitStyle:
                case eAttackResult.HitUnstyled:
                case eAttackResult.Missed:
                case eAttackResult.Parried:
                    //Condition percent can reach 70%
                    //durability percent can reach zero
                    // if item durability reachs 0, item is useless and become broken item

                    if (weapon != null && weapon is GameInventoryItem)
                    {
                        (weapon as GameInventoryItem).OnStrikeTarget(this, target);
                    }
                    //Camouflage
                    if (target is GamePlayer && HasAbility(Abilities.Camouflage))
                    {
                        CamouflageEffect camouflage = (CamouflageEffect)EffectList.GetOfType(typeof(CamouflageEffect));
                        if (camouflage != null)
                        {
                            DisableSkill(SkillBase.GetAbility(Abilities.Camouflage), CamouflageSpecHandler.DISABLE_DURATION);
                            camouflage.Cancel(false);
                        }
                    }
                    //Savagery targets
                    if (ad.AttackResult == eAttackResult.HitStyle)
                    {
                        byte targetToHit = 0;
                        int random;
                        IList targets = new ArrayList(1);
                        IList list = new ArrayList(1);
                        InventoryItem attackWeapon = AttackWeapon;
                        InventoryItem leftWeapon = (Inventory == null) ? null : Inventory.GetItem(eInventorySlot.LeftHandWeapon);
                        switch (style.ID)
                        {
                            case 374: targetToHit = 1; break; //Tribal Assault:   Hits 2 targets
                            case 377: targetToHit = 1; break; //Clan's Might:      Hits 2 targets
                            case 379: targetToHit = 2; break; //Totemic Wrath:      Hits 3 targets
                            case 384: targetToHit = 3; break; //Totemic Sacrifice:   Hits 4 targets
                            case 600: targetToHit = 100; break; //Shield Swipe: No Cap on Targets
                            default: targetToHit = 0; break; //For others;
                        }
                        if (targetToHit > 0)
                        {
                            if (style.ID != 600)
                            {
                                foreach (GamePlayer pl in GetPlayersInRadius(false, (ushort)AttackRange))
                                {
                                    if (pl == null) continue;
                                    if (GameServer.ServerRules.IsAllowedToAttack(this, pl, true))
                                    {
                                        list.Add(pl);
                                    }
                                }
                                foreach (GameNPC npc in GetNPCsInRadius(false, (ushort)AttackRange))
                                {
                                    if (GameServer.ServerRules.IsAllowedToAttack(this, npc, true))
                                    {
                                        list.Add(npc);
                                    }
                                }
                                list.Remove(target);
                                if (list.Count > 1)
                                    while (targets.Count < targetToHit)
                                    {
                                        random = Util.Random(list.Count - 1);
                                        if (!targets.Contains(list[random]))
                                            targets.Add(list[random] as GameObject);
                                    }
                                foreach (GameObject obj in targets)
                                {
                                    if (obj is GamePlayer && ((GamePlayer)obj).IsSitting)
                                    {
                                        effectiveness *= 2;
                                    }
                                    new WeaponOnTargetAction(this, obj as GameObject, attackWeapon, leftWeapon, CalculateLeftHandSwingCount(), effectiveness, AttackSpeed(attackWeapon), null).Start(1);  // really start the attack
                                }
                            }
                            else
                            {
                                foreach (GameNPC npc in GetNPCsInRadius(false, (ushort)AttackRange))
                                {
                                    if (GameServer.ServerRules.IsAllowedToAttack(this, npc, true))
                                    {
                                        list.Add(npc);
                                    }
                                }
                                list.Remove(target);
                                if (list.Count > 1)
                                    while (targets.Count < targetToHit)
                                    {
                                        random = Util.Random(list.Count - 1);
                                        if (!targets.Contains(list[random]))
                                            targets.Add(list[random] as GameObject);
                                    }
                                foreach (GameNPC obj in targets)
                                {
                                    if (obj != ad.Target)
                                        this.MakeAttack(obj, attackWeapon, null, 1, ServerProperties.Properties.SPELL_INTERRUPT_DURATION, false, false);
                                }
                            }
                        }
                    }
                    break;
            }
            return ad;
        }

As far as i've heard...Shield Swipe just does damage with your ActiveMainhand weapon to anything in radius (i made it 100cap atm) but it only Targets GameNPCs

[Graveen]

TY Mate, can you make us a patch ?

/bow

edit: or commit the changes yourself.

[Yemla]

i have like 1000s and 1000s of custom code in GamePlayer now so i had to patch it, it looks clean as far as i can tell but if it doesn't look perfect i can just make a Commition only folder if you'd like and svn commit?



Don't forget you have to remove in StylexSpell,

StyleXSpell_ID | SpellID |ClassID | SpellID | Chance
shieldswipe | 49990 | 0 | 600 | 100


otherwise it will stick have a DD proc which is a no-no

[stephenxpimentel]

another thing - when testing code to put into the SVN - make sure that it works in an up-to-date ONLY svn, custom code could bork its effects. like u said, an svn commit only source.

[Graveen]

Accepted, Thank you, soon in SVN !

[-Shawn-]

Graveen, I tested this code don't accept it... timers go crazy and freezes server when shield swipe is used on an npc

[geshi]

Code: Select all

                          if (list.Count > 1)
                                    while (targets.Count < targetToHit)
                                    {
                                        random = Util.Random(list.Count - 1);
                                        if (!targets.Contains(list[random]))
                                            targets.Add(list[random] as GameObject);
                                    }

This is bad.....

targetToHit = 100 (because it's Shield Swipe), but if there is not >100 targets in AttackRange then the while loop will go round and round and round and round and round till it goes B0000000M

[Graveen]

Thanks guys, obviously i missed the point in Yemla's code

[Tolakram]

Untested fix just committed. Someone test.


My god this code sucks.

[Graveen]

Question: if you quad hit (or triple hit, or double hit):

- you hit for the same damages as base hit ?
- you hit at the same location or you can hit base hit head, additional torso ?
- you can critical each additional hit, or you can only critical the base hit ?