Item proc and use level requirements?

[Tolakram]

I'm re-working some of the StartMagicalEffect and use item code to remove the requirement that it be in a spell line as well as in spells. I'm also having the Arrow code call the livings CheckMagicalEffect so we don't have the same code hanging out in two places.

If I'm not mistaken the requirement for proccing and using spells on an item is that the player must be at least the same level as the item. Is this correct?

[Tolakram]

Answering my own question.

Many level 50 items have a level requirement of 49, while some have a level requirement of 50. I hate the idea we have to have an entry in linexspell for every single proc at a different level when in fact the vast majority either proc at item level or item level -1. This makes maintenance of the procs and charges extremely tedious.

[stephenxpimentel]

Couldn't we just get rid of linexspell, and put level/spell-line in the spell DB? the majority of spells that repeat on 2 classes is the same line anyways, and then could just put all spells be available on items?

i think this is almost what u meant except for removing linexspell, which i realize would take quite a bit of work in the spell DB..

[Tolakram]

Linexspell is fine and needed for regular spells, it's just item effects and charges where this is an issue. The goal is to avoid duplicates as much as possible, and linexspell does that for standard spell lines. For procs and charges we know the type, the value, and what level the proc can be used on the item. For a damage proc of 95, for example, some items allow it to be used at 49 and some at 50, so two entries are required in linexspell for this proc/charge.

While I hate to add to itemtemplate I really think we need a new column to be used in a similar fashion to Bonuslevel. Perhaps UseLevel or Proclevel. When this is non zero the code will use it to determine level, otherwise it will use item level.

[Tolakram]

In addition, it appears the level requirement should only display once and not each time.

examples:





I am unable to find an item that has both charges and procs ... there has to be one somewhere.

[tobz]

josh beckett++

[Tolakram]

More examples.

[Tolakram]

Ok,

new column in ItemTemplate: LevelRequirement int

This will be used for procs and use.

If 0 then the item level (max of 50) will be used.

This will allow db editors to simply use or create spells for use without having to worry about looking up the spells in the Item Effects spell line or having to add it. Will be changing GameLiving, GamePlayer, DetailDisplayHandler, and ItemTemplate for this change.

[Graveen]

Thank you.

Alongside this, and with the huge changes i push to ItemTemplate, i hope Merec 'll agree to maintain ItemCreator

[Tolakram]

One more example, for a potion:

[stephenxpimentel]

i personally don't care but shouldn't LevelRequirement be a byte to be matched with majority of the other "Level" type stuff?

[Tolakram]

Hmmm. That's a good observation but since itemtemplate.level is an int I'm going to keep it as an int.