Global Constants Things Noticed

[Crazys]

Hey all
I was viewing global Constants and found
eInstrumentType
which was in correctly...
but then a bit father down the page i found
InstrumentType
which was identical to the top one.

Is there some reason we have both of these???
Just figured it would be something we could take out that was completely unnecessary code

Also ShieldLevel, its missing the naming format... of e....
I don't feel is named correctly... Technically its not the level its the size. So I vote it should be eShieldSize...

Thanks,
Crazys

[Graveen]

You are right, InstrumentType is not used.

For ShieldLevel, i agree too, anyway, you have to refactor this, if you can do it this is nice.

[Crazys]

You are right, InstrumentType is not used.

For ShieldLevel, i agree too, anyway, you have to refactor this, if you can do it this is nice.

Not a problem!!!
i don't know if it will be tonight but I'll have it updated and let you know!

Thanks,
Crazys

[Crazys]

Its been a bit since i've done an upload for you guys so let me know if I did anything wrong. I attached all the changes needed to change ShieldLevel to eShieldSize and removed the second listing of InstrumentType.

Thanks,
Kyle

[Crazys]

More Changes I would like to add to Global Constants

Please let me know if you approve of the following

(handles what slot an item is)
Current Name - Slot
Change to - eSlot

(handles cloth vs leather vs chain...)
Current Name - ArmorLevel
Change to - eArmorType

(to keep it uniform...)
Current Name - Gender
Change to - eGender

Let me know if you approve of any of these before i spend the time changing it to be what I feel would be unifrom with DoL
Thanks,
Crazys

[Graveen]

if theses are enums, yes, they should be prefixed with eXX

[Crazys]

if theses are enums, yes, they should be prefixed with eXX

I'll have all 3 changed tonight and the patch uploaded!

- I'll keep the patch separated from the one above -

Thanks,
Crazys

[Graveen]

Ok thank you !

[Crazys]

Patch Changes

(handles what slot an item is)
Current Name - Slot
Changed to - eSlot

(handles cloth vs leather vs chain...)
Current Name - ArmorLevel
Changed to - eArmorType

(to keep it uniform...)
Current Name - Gender
Changed to - eGender

Thanks,
Crazys