House for NPC

A place to submit .patch fixes for the DOL SVN

Moderator: Developer Team

House for NPC

Postby geshi » Sun Jul 25, 2010 1:00 pm

Hey when I load my server up I get spammed with
13:53:39,075 - [MAIN] - WARN - DOL.GS.GameObject - House for NPC xanxicarian elite doesn't exist !!!
13:53:39,076 - [MAIN] - INFO - DOL.GS.GameObject - NPC 'xanxicarian elite' added to house 65535

for every NPC in my DB, I then found this code..
Code: Select all
         if (m_houseNumber > 0 && !(this is GameConsignmentMerchant))
         {
            log.Info("NPC '" + Name + "' added to house " + m_houseNumber);
            CurrentHouse = HouseMgr.GetHouse(m_houseNumber);
            if (CurrentHouse == null)
               log.Warn("House " + CurrentHouse + " for NPC " + Name + " doesn't exist !!!");
            else
               log.Info("Confirmed number: " + CurrentHouse.HouseNumber.ToString());
         }


Is that an error??? If this is supposed to be for player houses then shouldn't it be if (m_houseNumber > 0 && (this is GameConsignmentMerchant)) ???? :(
geshi
Contributor
 
Posts: 1826
Joined: Tue Oct 21, 2008 9:16 pm

Re: House for NPC

Postby Tolakram » Sun Jul 25, 2010 1:20 pm

The housing code needs a lot of work. Generally, without even looking, I would say it's an error.

Someone (Blues?) did a ton of work to get housing where it is today, but it's very complex and needs a lot more work to get everything fixed.
- Mark
User avatar
Tolakram
Storm / Storm-D2 Admin
 
Posts: 9189
Joined: Tue Jun 13, 2006 1:49 am
Location: Kentucky, USA

Re: House for NPC

Postby elcotek » Sun Jul 25, 2010 3:39 pm

NPC 'xanxicarian' have an Housnumber on it, you must delete the number from mob in mob db.
Only NPC/Consignment from any House can have an Housenumber on it!
Brotherland Final RvR/PvE/ToA http://brotherland.phpbb8.de/
User avatar
elcotek
Server Representative
 
Posts: 177
Joined: Mon May 12, 2008 9:28 pm
Website: http://brotherland-2.de
Location: Germany

Re: House for NPC

Postby geshi » Sun Jul 25, 2010 4:45 pm

ah ok thx schnitte:)
geshi
Contributor
 
Posts: 1826
Joined: Tue Oct 21, 2008 9:16 pm


Return to “%s” DOL Code Contributions

Who is online

Users browsing this forum: No registered users and 1 guest