[committed] Two Bug Fixes

A place to submit .patch fixes for the DOL SVN

Moderator: Developer Team

[committed] Two Bug Fixes

Postby Kadorien » Mon Sep 20, 2010 9:13 am

I guess ear infections make me productive.

I've been looking around trying to find something quick / easy to do in case I get tired so I looked at the current bug report. I found two pretty simple bugs so I figured I'd submit the information to fix them:

First Bug - http://www.dolserver.net/?page=tracker&detail=15764
(People can grab hastener in combat so if they are fighting they can get away easily if theres a hastener near.)

It's a 2 part bug. I've got the first part working, looking into the second part.
Fix is attached in the hastener.patch


Second Bug - http://www.dolserver.net/?page=tracker&detail=15736
(The Liquification spec line gives 2 damage and debuff spells one aoe and one single target the single target at level 50 should debuff by 20% but only does 5% and the aoe should debuff 15% but only does 5%.)

Code: Select all
 //http://camelotherald.com/spells/spell.php?sp_id=2121
UPDATE spell SET value = 20 WHERE Name = "Searing Blast";

//http://camelotherald.com/spells/spell.php?sp_id=2127
UPDATE spell SET value = 15 WHERE Name = "Boiling Cloud";
Attachments
hastener.patch
Added a check for if player is in combat before applying hastener speed
(736 Bytes) Downloaded 17 times
Kadorien
DOL Novice
 
Posts: 57
Joined: Wed Sep 08, 2010 1:14 am

Re: Two Bug Fixes

Postby Etaew » Mon Sep 20, 2010 9:22 am

What is the behaviour on live regarding hastener and combat?

Also keep up the good work, I can see your making an effort to help out, and your on track to have that rewarded with your server group increase.
Retired DOL Enthusiast | Blog
User avatar
Etaew
Inactive Staff Member
 
Posts: 7602
Joined: Mon Oct 13, 2003 5:04 pm
Website: http://etaew.net
Location: England

Re: Two Bug Fixes

Postby Kadorien » Mon Sep 20, 2010 9:28 am

The thing with live is that there are no hasteners in locations that players would be in combat.

If someone has an active live account they could simply test the behavior in a duel and we would know for sure. Mythic, as far as I know, hasn't placed any hasteners in locations that would replicate the issue this player has run into.

With DOL being used in so many unique ways (server setups that is) it is a tough situation to look at. On one hand, yes DOL wants to replicate live DAoC as best as possible, on another hand the hastener is a simple script built into the source that has no boundaries. It is within the server admins choice to place a hastener in a location that could result in abuse, however I feel it's a moot point if in regards to this specific bug we follow Mythic's framework 100% since this NPC is not bound to Mythic's original construction and able to be used outside of their original vision.

With Mordred no longer active there are no PvP servers to test this on, but again, I feel Mythic would have solved this problem by simply not placing Hasteners near active PvP zones.
Kadorien
DOL Novice
 
Posts: 57
Joined: Wed Sep 08, 2010 1:14 am

Re: Two Bug Fixes

Postby Kadorien » Mon Sep 20, 2010 9:52 am

In regards to the second part of that bug:

I am able to reproduce the said problem however I am not sure how live handles the situation. I would assume that an arrow hitting a mob is the same as a caster hitting a mob or a player melee hitting a mob which would break speed.

I'm going to look further into this and see what I can find. I'll propose a solution if it is determined that this is in fact a bug and not a Live like event.
Kadorien
DOL Novice
 
Posts: 57
Joined: Wed Sep 08, 2010 1:14 am

Re: Two Bug Fixes

Postby Graveen » Mon Sep 27, 2010 2:15 pm

Accepted, thank you, soon in SVN!
Image
* pm me to contribute in Dawn of Light: code, database *
User avatar
Graveen
Project Leader
 
Posts: 12660
Joined: Fri Oct 19, 2007 9:22 pm
Location: France


Return to “%s” DOL Code Contributions

Who is online

Users browsing this forum: No registered users and 1 guest