[commit] Request: Max_group_members within DOLConfig (Patch)

A place to submit .patch fixes for the DOL SVN

Moderator: Developer Team

[commit] Request: Max_group_members within DOLConfig (Patch)

Postby Kadorien » Wed Sep 22, 2010 4:44 pm

I was reading through a thread earlier and saw a request to have Max group members controlled via DOLConfig like battle group members are. I was already working on this for my own server and saw some interest so I decided to create a patch.

Before I get to that I do have 1 question: Is there an easier way to create a patch with only the additions you chose? I had added both a group cap and a PvP group cap and I had to go through and remove all of the PvP group cap code to create a patch for this one section. Is there an easier way than back peddling to create patches?

I am unable to test this patch to it's full potential at the moment. I was able to compile with it, opened DOLServer and it booted up and DOLConfig contained the fields, I however am not able to access my server at the moment nor would have the bodies to fully test that it is functioning. It seems easy enough so I would assume it is good to go but if someone could test it that would be great.
Attachments
max_group_size.patch
Adds the ability for adjustment of Max Group Size from within DOLConfig.exe
(3.56 KiB) Downloaded 21 times
Kadorien
DOL Novice
 
Posts: 57
Joined: Wed Sep 08, 2010 1:14 am

Re: Request: Max_group_members within DOLConfig (Patch)

Postby Graveen » Wed Sep 22, 2010 5:24 pm

Thank you Kadorien.
Image
* pm me to contribute in Dawn of Light: code, database *
User avatar
Graveen
Project Leader
 
Posts: 12660
Joined: Fri Oct 19, 2007 9:22 pm
Location: France

Re: Request: Max_group_members within DOLConfig (Patch)

Postby Graveen » Mon Sep 27, 2010 2:11 pm

Although i think some scripts will need a minor tweak,

Accepted, thank you, soon in SVN
Image
* pm me to contribute in Dawn of Light: code, database *
User avatar
Graveen
Project Leader
 
Posts: 12660
Joined: Fri Oct 19, 2007 9:22 pm
Location: France

Re: Request: Max_group_members within DOLConfig (Patch)

Postby Kadorien » Mon Sep 27, 2010 3:09 pm

Graveen wrote:Although i think some scripts will need a minor tweak,

Accepted, thank you, soon in SVN


What changes need to occur. I've tested it on my server (with a lower cap than 8 and it worked for me)?
Kadorien
DOL Novice
 
Posts: 57
Joined: Wed Sep 08, 2010 1:14 am

Re: [commit] Request: Max_group_members within DOLConfig (Patch)

Postby Graveen » Mon Sep 27, 2010 3:47 pm

The changes are related to actually released scripts in support section. I saw some hardchecking the group cap number (8) directly.
Image
* pm me to contribute in Dawn of Light: code, database *
User avatar
Graveen
Project Leader
 
Posts: 12660
Joined: Fri Oct 19, 2007 9:22 pm
Location: France


Return to “%s” DOL Code Contributions

Who is online

Users browsing this forum: No registered users and 1 guest