[committed] Upnp support and some optimizations

[Dre]

Hello,

I added UPnP IGD support (see the patch below).
I do a small optimization in InventoryItem.Dirty (setter).

I optimized the KeepMgr.LoadHookPoints() method but I have a problem when I profile it. I have 11go of data instead of less than 1go for this method after optimization (I don't know why ) so this patch isn't included in UPnP patch.

PS: All patch were created in "DOLSharp/trunk/" but with GameServerScripts this time

[Graveen]

Thank you Dre, nice patchs.

I suppose the lambda you use in the keepmgr introduces the overhead. I'll review this before integration.

/wav

[Dre]

I did more search and I find this blog's article: http://my-tech-talk.blogspot.com/2009/0 ... er-is.html
So I think that it's a bug of VS 2008 profiler... I'll test with another profiler when I can

[Graveen]

sharpdevelop 4 's built-in one.

[Graveen]

Accepted, thank you, soon in SVN !

[Graveen]

I can't have the uPNP working

Basically, Dawn of Light should

1) check if uPNP universal host service is running
2) find an uPNP device
3) add rules tcp 10300 udp 10400 to the gateway

We agree bout this ?

[Dre]

I can't have the uPNP working

Basically, Dawn of Light should

1) check if uPNP universal host service is running
2) find an uPNP device
3) add rules tcp 10300 udp 10400 to the gateway

We agree bout this ?

Not really, the "UPnP universal host service" can be activated on a computer sharing its connection, it will turn it into UPnP IGD (see: http://support.microsoft.com/kb/323713) but I didn't tested it and you don't need it on host of dol. I will test it on Windows 7 and vmware

For having UPnP, you need an UPnP IGD in your LAN (in France, many box have this features). This UPnP implementation broadcast a discorey packet (see "UPnPNat.Discover()") and wait for a response of a UPnP IGD.

There are a small problem, UPnP is based on SSDP and it's an expired draft so maybe some device aren't recognized (see: http://en.wikipedia.org/wiki/Simple_Ser ... y_Protocol).

[Dinberg]

I can't have the uPNP working

Basically, Dawn of Light should

1) check if uPNP universal host service is running
2) find an uPNP device
3) add rules tcp 10300 udp 10400 to the gateway

We agree bout this ?

No, because those are magic numbers

I think you mean to check the config file for its udp/tcp port setup and add those entries, for those of us who dont want to use 10300/10400 for dawn of light ^^

[Dre]

Not really, the "UPnP universal host service" can be activated on a computer sharing its connection, it will turn it into UPnP IGD (see: http://support.microsoft.com/kb/323713) but I didn't tested it and you don't need it on host of dol. I will test it on Windows 7 and vmware

I tested with Windows 7, it was not working completely, there is the bugfix.
So actually, UPnP has been tested with Freebox (French ISP's box) and Windows IGD if you have another devices to test... (I don't have another UPnP IGD)

[Graveen]

Dinny, i mean the process to connect, the ports are effectively embedded.


Dre, i was targetting upnp nat translation, via upnp igd. As this is an interesting topic i never throw an eye, i gave a look at former uPnP protocols, associated structures and the current code.

There are 2 problems:
- the fact it is locked on the s.receive()
- the fact it is not working


Basically, TimeSpan trick for timeout is not working. I worked with the Harold Aptroot's code ( http://www.codeproject.com/KB/IP/upnpnattraversal.aspx ) - the UPnPNat class you pushed in DOL - and i was not able to have it working on my lan. In fact, after some deep test, the fwk 2.0 socket.Receive() is *not* blocking, while fwk 3.5 one is... Here is the first problem.
Second, my router is not found by Harold's code. it is a perfect UPNP IGD device anyway, but i assume this code is deprecated or too much linked in fwk 2.0.

Basically, i expect rougly what i describe:
- detect any upnp igd device
- open dol ports
- close them after server is not running

DoL must map automagically the ports, similar to what uTorrent is performing, else this is breaking the need for it, and the ease it brings. TBH i troubleshooted Harold's code and get it working with fwk 3.5, so i should fix it soon, perhaps this evening.

[Graveen]

Ah bah excellent, this evening i'll test it