New Command : /gmstealth

[-Shawn-]

Code: Select all

using System;
using System.Collections.Generic;
using DOL.GS.Commands;
using DOL.GS;
using DOL.GS.PacketHandler;

namespace DOL.GS.Commands
{
    [CmdAttribute(
        "&gmstealth",
        ePrivLevel.GM,
        "Grants the ability to stealth to a gm/admin character")]
    public class GMStealthCommandHandler : AbstractCommandHandler, ICommandHandler
    {
        public void OnCommand(GameClient client, string[] args)
        {
            if (client.Player.IsStealthed != true)
            {
                client.Player.DBCharacter.MaxSpeed = 400;
                client.Player.Stealth(true);
            }
            else
                client.Player.Stealth(false);
            client.Player.DBCharacter.MaxSpeed = 191;
        }
    }
}
   

just a little near command for people; also took your advice graveen

[Graveen]

what was my advice ? that this command is not reliable due to stealth detection routine ???

[-Shawn-]

No ;p the one that was hardcoding is messy and unnecessary

[Graveen]

I agree for this one

[stephenxpimentel]

maybe add this to /player? /player stealth <spec Level> and it will make the target (player, GM, or admin) stealth with the specified spec level?

[Dream]

Shawn made this for my server and it works well.
Its impossible for any other player to see you, works just like Edens /stealth command as i asked

As I said works well with no problems

[-Shawn-]

maybe add this to /player? /player stealth <spec Level> and it will make the target (player, GM, or admin) stealth with the specified spec level?

Well, I like the ideas for a player, but regardless of stealth level gms/admins can not be seen while stealthed just saying xD

[Graveen]

The more problematic point with your code is the speed change, that 'll remain in the database, if you don't use your command again so you *must* use a temp property. But i suggest to not care about the speed, and extend the command to allow GM to give temp stealth to players (or themselves).

Yes, put it in /player, no target = target the gm issuing the command.

[-Shawn-]

Code: Select all

using System;
using System.Collections.Generic;
using DOL.GS.Commands;
using DOL.GS;
using DOL.Database;
using DOL.GS.PacketHandler;

namespace DOL.GS.Commands
{
    [CmdAttribute(
        "&gmstealth",
        ePrivLevel.GM,
        "Grants the ability to stealth to a gm/admin character",
        "/gmstealth on : turns the command on",
        "/gmstealth off : turns the command off")]
    public class GMStealthCommandHandler : AbstractCommandHandler, ICommandHandler
    {
        public void OnCommand(GameClient client, string[] args)
        {
            if (args[1].ToLower().Equals("on"))

                if (client.Player.IsStealthed != true)
                {
                    client.Player.DBCharacter.MaxSpeed = 191;
                    client.Player.Stealth(true);
                }
                else if (args[1].ToLower().Equals("off"))
                {
                    client.Player.Stealth(false);
                    client.Player.DBCharacter.MaxSpeed = 191;
                }
        }
    }
}


hows this ?

[Graveen]

there is no need to change the speed. You *must* not assume a gm char is forced to run at 191 ?!?

[-Shawn-]

Ah, so just remove the speed? Also do you want to keep the case on/off or ?

[Leodagan]

I updated this one...

Removed speed modifier, changed how arguments are handled, added syntax display, added comment header with dol text.

[Graveen]

Thank you Leodagan. Can you commit it please, in commands/GMs ?

Please ensure the GPL header is set.
Please read and understand the commit guidelines: http://www.dolserver.net/viewtopic.php?f=47&t=13937

Thanks again

[Leodagan]

I'll try to commit it when I'll finish reading the guidelines

In my DOL project this script is in GSS, I don't know if it should go in GSS class or GS class on Core (this thing acutally just gives stealth to GM/Admin that don't use a stealther char...)

[Graveen]

Oops, my bad, i think it was an easy way to make a GM invisible to players (like a 666 model with no weapons)