[Committed] MoveItem & AllowedClasses || Housing Vault

A place to submit .patch fixes for the DOL SVN

Moderator: Developer Team

[Committed] MoveItem & AllowedClasses || Housing Vault

Postby Shursan » Wed Dec 08, 2010 1:05 am

Hi,

The patch for moveitem allow the client to move these allowedclasses in a vault inventory .. etc.

The patch for housing vault fix a recent problem, if you have a vault somewhere in a house, shutdown the server, and restart it, the vault add to the database each time .. if you have 50 vault, next restart you have 100 :)
Attachments
PatchHouseVaultAndMoveItem.patch
(6.42 KiB) Downloaded 19 times
Origins/Genesis Administrator
Shursan
Server Representative
 
Posts: 375
Joined: Mon Jun 22, 2009 8:25 pm
Location: France

Re: MoveItem & AllowedClasses || Housing Vault

Postby Tolakram » Wed Dec 08, 2010 1:20 pm

Oh hey, look at that. I'll review these later, but I think I like the vault fix.
- Mark
User avatar
Tolakram
Storm / Storm-D2 Admin
 
Posts: 9189
Joined: Tue Jun 13, 2006 1:49 am
Location: Kentucky, USA

Re: MoveItem & AllowedClasses || Housing Vault - Committed

Postby Tolakram » Fri Dec 10, 2010 11:40 pm

Committed. Thanks for fixes!
- Mark
User avatar
Tolakram
Storm / Storm-D2 Admin
 
Posts: 9189
Joined: Tue Jun 13, 2006 1:49 am
Location: Kentucky, USA

Re: [Committed] MoveItem & AllowedClasses || Housing Vault

Postby Shursan » Thu Dec 16, 2010 1:53 am

More good with the following patch, the last appears to broke the new vault to register in the db :)
Attachments
AttachVault.patch
(1.95 KiB) Downloaded 15 times
Origins/Genesis Administrator
Shursan
Server Representative
 
Posts: 375
Joined: Mon Jun 22, 2009 8:25 pm
Location: France

Re: [Committed] MoveItem & AllowedClasses || Housing Vault

Postby Tolakram » Thu Dec 16, 2010 2:33 am

That patch does not work with latest SVN. Are you sure there's a bug? Not sure what you are trying to fix.
- Mark
User avatar
Tolakram
Storm / Storm-D2 Admin
 
Posts: 9189
Joined: Tue Jun 13, 2006 1:49 am
Location: Kentucky, USA

Re: [Committed] MoveItem & AllowedClasses || Housing Vault

Postby Shursan » Thu Dec 16, 2010 3:23 am

i think there's a bug yes, (or a svn error possibly when i have updated ..)
If you remove the first patch, test to load and shutdown your serer with one vault register in the db. Next restart if there's really an error, your chest are duplicated.

I test that tomorrow with a fresh svn, before the commit of my patch.
Origins/Genesis Administrator
Shursan
Server Representative
 
Posts: 375
Joined: Mon Jun 22, 2009 8:25 pm
Location: France

Re: [Committed] MoveItem & AllowedClasses || Housing Vault

Postby Shursan » Fri Dec 17, 2010 1:44 am

bug confirmed with a svn rev 2718.

how to reproduce:

1: run this querry, juste for verify the count
select * from househookpointitem where itemtemplateid like "%vault";
2 start a dolserver rev 2718
3 when up shut down it, remake the query, all vault are duplicated in the db :)

my first patch fix it, so he's not reliable, because he don't allow new vault to be added to the db.

with my second patch all is fixed. i commit it.
Origins/Genesis Administrator
Shursan
Server Representative
 
Posts: 375
Joined: Mon Jun 22, 2009 8:25 pm
Location: France


Return to “%s” DOL Code Contributions

Who is online

Users browsing this forum: No registered users and 1 guest