Invisible Character Prevention.

[Ephemeral]

Since I recently saw a thread on a forum about how people can do this with cheat engine, I added a little fix into the faith core to prevent it, and if it works (It should, I think) then it should probably be in the public core as well.

Removed link because its probably a bad idea.

(I couldn't figure out how to make a patch file from this, its in two diff SVN's)

Code: Select all

if (ch.Race == (byte)eRace.AlbionMinotaur || ch.Race == (byte)eRace.MidgardMinotaur || ch.Race == (byte)eRace.HiberniaMinotaur)
{

if(ch.Gender != 0)
{
if (log.IsWarnEnabled)

log.Warn("Wrong gender for minotaur race: " + ch.Realm);


if (ServerProperties.Properties.BAN_HACKERS)
{
DBBannedAccount b = new DBBannedAccount();
b.Author = "SERVER";
b.Account = ch.AccountName;
b.DateBan = DateTime.Now;
b.Type = "A";
b.Reason = String.Format("Auto-ban InvalidGender '{0}' on invalid minotaur. Account '{1}'", GameServer.Database.Escape(ch.Name), GameServer.Database.Escape(ch.AccountName));
GameServer.Database.AddObject(b);
GameServer.Database.SaveObject(b);
GameServer.Instance.LogCheatAction(string.Format(b.Reason + ". Client Account: {0}, DB Account: {1}", ch.AccountName, ch.AccountName));
}

valid = false;
}
}

Put it anywhere in the try section with the other checks in the file

GameServer/packets/Client/168/CharacterCreateRequestHandler

Its in the character valid check.

Code: Select all

public static bool IsCharacterValid(DOLCharacters ch)

Updated post thanks to
[20:24] <@Tolakram> gender in db is 0=male, 1=female enum is 0=neutral, 1=male, 2=female. DOL code is awesometastic

[Tolakram]

Females aren't allowed? I had no idea.

What's the real problem here though. Why is the toon invisible? Invalid model?

[geshi]

Tola, check Developer Forum !

[Ephemeral]

I assume its because the client tries to set an invalid model for a female minotaur, and that gets sent to the server (well hm, Just realized it could be done with a model check as well, but this is probably simpler to write) and then the other clients try to display that an all, and they fail.

[Etaew]

Thank you for notifying us about this vulnerability.

[Graveen]

God, this is the first usefull patch from Haji !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Accepted, soon in SVN, thank you !

[geshi]

God, this is the first usefull patch from Haji !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Accepted, soon in SVN, thank you !

Don't forget his major vamp fix too ! having 0 WS sucked !

[Ephemeral]

God, this is the first usefull patch from Haji !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Accepted, soon in SVN, thank you !

See post below yours.


:< And don't be hating, my big thing is gonna be the antihack which none of you will ever use.

[Tolakram]

The invisible player is a result of the languagemanager failing to come up with a race name and spamming the lookup text. The carelessness at which languagemgr was written is a constant thorn in my side.

In addition, the Gender enum does NOT map to dolcharacter gender.

[Ephemeral]

The invisible player is a result of the languagemanager failing to come up with a race name and spamming the lookup text. The carelessness at which languagemgr was written is a constant thorn in my side.

In addition, the Gender enum does NOT map to dolcharacter gender.

- WHY -

FFS, where else would that gender apply?

[Dinberg]

The beauty of open source. So beautiful.