Thuergist Pet Fix

[Hiatus]

- Thuergist Pets should now Stop attacking, and stop chasing players that have stealthed.
http://www.dolserver.net/storm/tracker/?issue=15322


- Hiatus


Sadly for some reason, I cannot upload the patch file (I think it is a bug) so I have posted it below. [Already told Etaew about this might have only been me]

Code: Select all

Index: DOLSharp/trunk/GameServer/ai/brain/Theurgist/TheurgistPetBrain.cs
===================================================================
--- DOLSharp/trunk/GameServer/ai/brain/Theurgist/TheurgistPetBrain.cs (revision 2879)
+++ DOLSharp/trunk/GameServer/ai/brain/Theurgist/TheurgistPetBrain.cs (working copy)
@@ -78,9 +78,11 @@

protected override void AttackMostWanted()
{
+
if (!IsActive || !m_active) return;
if (m_target == null) m_target = (GameLiving)Body.TempProperties.getProperty<object>("target", null);
if (m_target == null) return;
+ if (m_target.IsStealthed == true) { Body.StopMoving(); Body.MaxSpeedBase = 0; Body.StopAttack(); }
GameLiving target = m_target;
if (target != null && target.IsAlive)
{
@@ -91,6 +93,7 @@
}
else
{
+
m_target = null;
m_active = false;
Body.StopMoving();

[Etaew]

Why set the MaxSpeedBase to 0? StopMoving() should stop the NPC from moving, changing the max speed will probably prevent it from returning to spawn.

[Tolakram]

It's a temp pet, so it's supposed to just stand there until it dies.

Permission issues on the uploads Hiatus, our crack web staff is working on it.

[Etaew]

Ah I didn't read the Theurgist part

So much for crack web staff...

[Dinberg]

How does this work with respect to the stealthed player unstealthing and the pets are ranged (such as the casting ones) - will they be able to continue an attack at range?

[Crazys]

How does this work with respect to the stealthed player unstealthing and the pets are ranged (such as the casting ones) - will they be able to continue an attack at range?

Do you attempt to attack again????
I thought once targeting was lost they would not reingage.... Possibly something to test on live?

[Hiatus]

How does this work with respect to the stealthed player unstealthing and the pets are ranged (such as the casting ones) - will they be able to continue an attack at range?

Do you attempt to attack again????
I thought once targeting was lost they would not reingage.... Possibly something to test on live?

This statement is correct, I would go more in depth into this but currently I'm at work so, I will if it is not explain or said by the time I'm home

[Graveen]

Accepted, thank you, soon in SVN

I'll wait you next patch, for removing the player for the aggrolist

[Hiatus]

How does this work with respect to the stealthed player unstealthing and the pets are ranged (such as the casting ones) - will they be able to continue an attack at range?

They shouldn't re-aggro I will read the stop attack method when I get home and see how it us handle otherwise my answer for now is no, they should not re-engage.

[Dinberg]

Cool, just checking - it was something I thought might have been missed

[Argo]

Seeing this reminds me that the cabby pets do not attack stealthed mobs since they are not allowed to attack any stealthed player. I think for any other pet class this will be the same. Anyone upto writing a fix for that ?

[geshi]

Seeing this reminds me that the cabby pets do not attack stealthed mobs since they are not allowed to attack any stealthed player. I think for any other pet class this will be the same. Anyone upto writing a fix for that ?

Yes, it's the case with all pets.

Should the mob pop out off stealth when attacked and pop back in to stealth after a period of time? or should it just stay in stealth?

[Tolakram]

This might be fixed as something D2 needs for the PvP arena.

[Argo]

Seeing this reminds me that the cabby pets do not attack stealthed mobs since they are not allowed to attack any stealthed player. I think for any other pet class this will be the same. Anyone upto writing a fix for that ?

Yes, it's the case with all pets.

Should the mob pop out off stealth when attacked and pop back in to stealth after a period of time? or should it just stay in stealth?

attacking a stealthed mob should consist of the following steps:
stealthed mob gets attacked
mob pops out of stealth
mob is defeated by player -> everything is okay
player is defeated by mob or player runs away -> mob pops in to stealth again after a while

but before all this happens the pet classes must be able to attack a stealthed mob

kind regards
Argo

[Hiatus]

Yes, that shouldn't be too hard