Removal of Attempted remake in DOL core for Brain

A place to submit .patch fixes for the DOL SVN

Moderator: Developer Team

Removal of Attempted remake in DOL core for Brain

Postby Crazys » Mon May 16, 2011 3:57 pm

After talking with Tol i'm requesting that we r emove the entire NPCs folder inside Gameserver/AI/Brain

After removing the entire fold and recomplinign no errors. There are no scripts in here that are being utilized anywhere else in the core. This was the attempted remake thatw as never completed to remake the nPC brain and at this point is just taking up space.

Tol was also mentioning putting IOldAggresiveBrain.cs back to IAggresiveBrain.cs
Crazys
Contributor
 
Posts: 346
Joined: Tue Nov 07, 2006 10:18 pm

Re: Removal of Attempted remake in DOL core for Brain

Postby Graveen » Mon May 16, 2011 5:23 pm

yep sure, except if this throw a (possible and reliable) basis to the dark void.
Image
* pm me to contribute in Dawn of Light: code, database *
User avatar
Graveen
Project Leader
 
Posts: 12660
Joined: Fri Oct 19, 2007 9:22 pm
Location: France

Re: Removal of Attempted remake in DOL core for Brain

Postby Crazys » Mon May 16, 2011 5:50 pm

yep sure, except if this throw a (possible and reliable) basis to the dark void.
Per what Tolakram had mentioned
Aredhel had started the process of recreating the brain in the dol core and what is left of it is in the folder i had mentioned. It is not connected into the core or used by anything currently. I don't see why we are complieing it when its not used by anything. IF you wanted to keep it in an older folder outside of the core i would understand... Just since noone has worked in it in 2 years. Time to move on?
Crazys
Contributor
 
Posts: 346
Joined: Tue Nov 07, 2006 10:18 pm

Re: Removal of Attempted remake in DOL core for Brain

Postby Dinberg » Mon May 16, 2011 6:13 pm

"Time to move on?" suggests this would be a forward development. I believe this would actually be a regression, and I'm going to position my advice against removing the folders from core. The changes are incomplete, but Aredhel's code was good in design, and superior to the current SMB.

In short: dont remove it
The Marvelous Contraption begins to stir...
User avatar
Dinberg
Inactive Staff Member
 
Posts: 4695
Joined: Sat Mar 10, 2007 9:47 am
Yahoo Messenger: dinberg_darktouch
Location: Jordheim

Re: Removal of Attempted remake in DOL core for Brain

Postby Tolakram » Mon May 16, 2011 6:24 pm

I would not worry about it crazys. I'll most likely rename it to new and remove old from the current brains. No need to remove it from the core. OldAgressiveBrain pisses me off. Sounds too much like me.
- Mark
User avatar
Tolakram
Storm / Storm-D2 Admin
 
Posts: 9189
Joined: Tue Jun 13, 2006 1:49 am
Location: Kentucky, USA

Re: Removal of Attempted remake in DOL core for Brain

Postby Crazys » Mon May 16, 2011 6:52 pm

"Time to move on?" suggests this would be a forward development. I believe this would actually be a regression, and I'm going to position my advice against removing the folders from core. The changes are incomplete, but Aredhel's code was good in design, and superior to the current SMB.

In short: dont remove it
so you rather seee someone move forward with it then remove it gotcha
Crazys
Contributor
 
Posts: 346
Joined: Tue Nov 07, 2006 10:18 pm

Re: Removal of Attempted remake in DOL core for Brain

Postby Dinberg » Tue May 17, 2011 8:16 am

Yeah; the ideas inside that code were really really nice, its such a pity they were never completed. Hopefully someone might make use of it someday :D
The Marvelous Contraption begins to stir...
User avatar
Dinberg
Inactive Staff Member
 
Posts: 4695
Joined: Sat Mar 10, 2007 9:47 am
Yahoo Messenger: dinberg_darktouch
Location: Jordheim


Return to “%s” DOL Code Contributions

Who is online

Users browsing this forum: No registered users and 1 guest