Adding in the stuck command

[Hiatus]

http://www.dolserver.net/storm/tracker/?issue=14861


The title says it all, the stuck command currently implemented does nothing. My patch will locate the last saved location and port them there. Since the Client updates faster than the DB it pulls saved locs from the DB and moves them back in their last saved walking path.


Edit : Tested also by the way, and it works. @Etaew if you read this, you said I could use the tracker (edit etc) I couldn't figure out how. Maybe I'm blind but I couldn't see how to change status' etc.

[Etaew]

Thank you for yet another patch Hiatus.

Are you running any server at the moment that we should be crediting?

It appears I haven't allowed Contributors the ability to access the Tracker. I now have. Give it a go.

[Hiatus]

Currently in the making I haven't quite picked out a name yet. So I used my DOL forums name. I plan to possibly change that soon.

[Hiatus]

I have edited all of the patches that I currently am working on...it works

[Etaew]

That should make things easier Keep up the good work.

Of course, any suggestions as to tracker improvements are welcome.

[geshi]

/stuck afaik was working about a year ago

[Hiatus]

/stuck afaik was working about a year ago

It currently does not even work on storm, I was playing my hunter and I used a portal(it was next to a tree) and then I was stuck in the tree. All it did was log me out just like the quit command. And that tracker patch was made a year ago

[geshi]

ah, I probably got live confused with shards then.

good job

[Dunnerholl]

actually...after reviewing code :

remove the property "Stuck" from GamePlayer, as it became useless by your fix


i think some time ago the plan was:

to set stuck flag on gameplayer
logging him out
in loginhandler stuck flag should be then handled
(last step is missing)

i prefer your way of handling it all in the stuck handler
if someone thinks "why log out at all?" the logout is required anyway because of abuse if you effectively make this a jump command

[Dunnerholl]

actually...after reviewing code :

remove the property "Stuck" from GamePlayer, as it became useless by your fix


i think some time ago the plan was:

to set stuck flag on gameplayer
logging him out
in loginhandler stuck flag should be then handled
(last step is missing)

i prefer your way of handling it all in the stuck handler
if someone thinks "why log out at all?" the logout is required anyway because of abuse if you effectively make this a jump command

i was wrong:
(in public override void SaveIntoDatabase()/GamePlayer)

Code: Select all

if (m_stuckFlag)
{
lock (m_lastUniqueLocations)
{
GameLocation loc = m_lastUniqueLocations[m_lastUniqueLocations.Length - 1];
m_dbCharacter.Xpos = loc.X;
m_dbCharacter.Ypos = loc.Y;
m_dbCharacter.Zpos = loc.Z;
m_dbCharacter.Region = loc.RegionID;
m_dbCharacter.Direction = loc.Heading;
}
}

this has to be removed/handled/cared about too then

question is, why didnt it work? how is it different from your approach?

[Tolakram]

Are we positive stuck did not work? I know there are instances where it might not work, like if lastuniquelocation is bad, but it seems like this should work most of the time.

[Hiatus]

I tested the command several times, surprisingly I did do find all references on the code but I did not find that code. So my bad on my part for not seeing that. Wouldn't it be better handled in the script itself rather than GamePlayer?

[Graveen]

At first sight, this could be better in a separate command, except if the access level of m_lastuniquelocation is somehow restricted in purpose.

[Hiatus]

So, would you like me to add to the patch to remove the stuck flags etc?

[Graveen]

Thank you for your work, i'll carefully look at it, no decisions atm