Pet - Go To Checks

[Etaew]

As found on the Dominvm forums, as they use outdated code I had to check ours. And it seems we don't have any target in view or range checks.

I don't know if these checks are from live, but it makes sense to me.

http://dominivm.org/forum/showthread.ph ... 38#pid5138

Obviously message feedback is required too

[Hiatus]

I can't register ;/

[Etaew]

I can't register ;/

Ah yes, I had to register too.

Is annoying, they should make the forum public.

[geshi]

It says you have to register at http://dominivm.org/administrator/index.php ..

When I try I get the error "Username and password do not match"

[Etaew]

I used the register link on the dominivm.org home page.

[Tolakram]

Sorry but you cannot register at this time because the administrator has disabled new account registrations.

edit: I was able to register from their homepage.

[Etaew]

Anyway, I won't make a patch at the moment. In case you can't visit their forum.

This is some thrown together code to not allow a pet to be moved to a target if you cant see the target. Perhaps a message should be sent to the player too.

Code: Select all

public virtual void CommandNpcGoTarget()
{
IControlledBrain npc = ControlledBrain;
if (npc == null)
return;

if (npc.Body.IsConfused) return;

GameObject target = TargetObject;
if (target == null)
{
Out.SendMessage(LanguageMgr.GetTranslation(Client, "GamePlayer.CommandNpcGoTarget.MustSelectDestination"), eChatType.CT_System, eChatLoc.CL_SystemWindow);
return;
}

//Etaew - check target in view
if (!m_targetInView)
return;
//end Etaew
Out.SendMessage("You command " + npc.Body.GetName(0, false) + " to go to your target.", eChatType.CT_System, eChatLoc.CL_SystemWindow);
npc.Goto(target);
}

[Dinberg]

When does targetInView get updated? I think it would be better to end this void with a LOScheckRequest to the client, then send the pet to the target in the callback of the los check's reply if it can be seen.

[Tolakram]

TargetInView is not 100% reliable, might not even be 10% reliable. It is set on the client if the client can clearly tell your target is not in view (behind a fixed client structure). The bit is set on the client and updated during the player position update (this is my best guess). Only LOS calls will be 100% accurate, though if TargetInView is false you can be fairly certain LOS will fail as well.

[Dinberg]

Good call, I like that; use the targetInView to check whether to send the los.