[committed] Spell Effects incorrect on Pet Damage Shield

[darkpoetcc]

When a Pet Damage Shield is being cast, the Spell Effect that is shown is around the Caster, whereas it should be shown around the summoned pet.

The code shown here:

Code: Select all

// show animation on caster for positive spells, negative shows on every StartSpell
if (m_spell.Target == "Self" || m_spell.Target == "Group" || m_spell.Target == "Pet")
SendEffectAnimation(Caster, 0, false, 1);

Should be similar the code here:

Code: Select all

// show animation on caster or pet for positive spells, negative shows on every StartSpell
if (m_spell.Target == "Self" || m_spell.Target == "Group")
{
//Show effects on the Caster
SendEffectAnimation(Caster, 0, false, 1);
}

if (m_spell.Target == "Pet")
{
//Show effects on the Controlled Pet
SendEffectAnimation(m_spellTarget, 0, false, 1);
}

In my testing, it has resolved the issue and the Spell Effect shows around the pet when the Damage Shield is cast. I tested this with a Cabalist in order to verify it show as have seen within the game on the live Mythic servers.

The issue resides in the SpellHandler.cs code file, which resides in the GameServer project.

[Graveen]

thank you DarkPoetcc, this is effectively a proper report.

[Etaew]

Ah, you explained this well, and provided some code to back it up and a suggested solution. Perfect post

[Phen]

this always kind of annoyed me on my Cabalist

[Graveen]

Accepted, soon in SVN, thank you

[darkpoetcc]

Very welcome! Glad I could be of assistance in some small way

[Dinberg]

Bravo sir! A good example of how to contribute