ShieldSwipe Patch Appears to be broken in current state

[Crazys]

Update to coding for Shield Swipe handling in gameplayer
Line 6478 in Game Player Changed Group for Shieldswipe to the following
previous version did not hit players. Did not appear to hit anything. Had limitations. Only limits should be in range and can attack for shieldswipe.

Code: Select all

else // shield swipe
{
foreach (GameNPC npc in GetNPCsInRadius(false, (ushort)AttackRange))
{
if (GameServer.ServerRules.IsAllowedToAttack(this, npc, true))
{
listAvailableTargets.Add(npc);
}
}
foreach (GamePlayer pl in GetPlayersInRadius(false, (ushort)AttackRange))
{
if (pl == null) continue;
if (GameServer.ServerRules.IsAllowedToAttack(this, pl, true))
{
listAvailableTargets.Add(pl);
}
}
if (listAvailableTargets.Contains(target) == true)
{
listAvailableTargets.Remove(target);
}
foreach (GameLiving obj in listAvailableTargets)
{
this.MakeAttack(obj, attackWeapon, null, 1, ServerProperties.Properties.SPELL_INTERRUPT_DURATION, false, false);
}
}

[rdsandersjr]

Probably the changes grav made with isallowedtoattack earlier?

[Graveen]

'll check, my change implies pet & gameplayer. TBH my changes'll be modified - it broke necros - and leave IsAllowedToAttack() as it was.

[Crazys]

I still feel the old code had to much triple checking and unneeded random function. Also did not include players. So either way an update is still needed wether it be this 1 or a different 1

[Tolakram]

No, this is an old bug.

Why don't we add ExtraTargets and IsExtraRandom columns to the style table so we don't have to use hard coded stuff in gameplayer? This would also allow for more customization options.

[Graveen]

To qualify a multi hit style, what do we need ?

- range
- max target
- type of effect (cone, pbaoe)

You see more to use ?

[Crazys]

To qualify a multi hit style, what do we need ?

- range
- max target
- type of effect (cone, pbaoe)

You see more to use ?

Per Live... This is all that is needed.
Although per previous testing i believe shield swipe was an AoE off your target not off yourself (i could be wrong). This may also need to be changed in current coding context...

[Dinberg]

Yeah I think it was AoE when I played. Perhaps this was changed in the shield overhaul?

[Graveen]

honestly i doubt we can see if it is AOE based on target or AOE based on tank performing ss. Let's consider it is logically an aoe based on the tank.

[Crazys]

If i'm not mistaken it was off the target. If my target was ontop of me the farthest effected target was closer... farther out... could be farther away... If your assuming the its a pbae the range would have to be increased... since most NPCs would not fall within the range of your swipe where ae off the target tehy do

[Dinberg]

Pretty sure the AoE was target based, I remember thinking it was a little odd at the time.