SendTrainerWindow (1105)

[Xaves]

Ok two things:
1. Right now the trainer window shows an additional non existent realm ability, this is infact the rr5 ability, which is skipped and thus not shown, but its place is reserved because the amount of realmabilities is set to the full value instead of Count - 1 (line 282)

Code: Select all

// type 5 (realm abilities)
List<RealmAbility> ras = SkillBase.GetClassRealmAbilities(m_gameClient.Player.CharacterClass.ID);
using (var pak = new GSTCPPacketOut(GetPacketCode(eServerPackets.TrainerWindow)))
{
pak.WriteByte((byte)(ras.Count - 1));
pak.WriteByte((byte)m_gameClient.Player.RealmSpecialtyPoints);

2. The first part of realmabilites (line 78) in the method looks unnecessary to me, prove me wrong but I removed it and everything was still working fine.

[Dunnerholl]

2. The first part of realmabilites (line 78) in the method looks unnecessary to me, prove me wrong but I removed it and everything was still working fine.

if you talk about this line and want feedback, better to post it and all its context

[Xaves]

Well, sorry. I meant the line and its following
from line 78 to line 130 in the current PacketLib1105

[Graveen]

To mimic the original packets. I have dumped the whole thing and reversed the frames. My goal was to strictly implement original packets.

Darwin also worked on implementing new trainer window. It can effectively work w/o some parts, but you should check with the logguer and compare to live in both cases to really see if this is redundant