[committed] [Fix]ABS-UnstyleDamageCap

A place to submit .patch fixes for the DOL SVN

Moderator: Developer Team

[committed] [Fix]ABS-UnstyleDamageCap

Postby Centurio » Thu Sep 08, 2011 8:22 am

Here a patch that fix some things in GamePlayer class.

-Added TOA bonus in calculation of UnstyleDamageCap
-Added the quality of the item in GetArmorAbsorb..abs is related to quality.
-Fixed the 2Hand bonus on AttackDamage, with the formula : 10% + (Skill / 2)
Attachments
GamePlayer.patch
(2.44 KiB) Downloaded 34 times
Last edited by Centurio on Thu Sep 08, 2011 8:42 am, edited 1 time in total.
Heavy metal is The law
User avatar
Centurio
DOL Acolyte
 
Posts: 142
Joined: Tue Feb 13, 2007 10:51 pm
Website: http://www.myspace.com/pagandio

Re: [Fix]ABS-UnstyleDamageCap

Postby Dunnerholl » Thu Sep 08, 2011 8:27 am

where do you get the knowledge that absorb is modified by quality? and where is the 2h bonus formula taken from?
Dunnerholl
Developer
 
Posts: 1229
Joined: Mon Sep 08, 2008 8:39 pm

Re: [Fix]ABS-UnstyleDamageCap

Postby Graveen » Thu Sep 08, 2011 8:41 am

Thank you Centurio !
Image
* pm me to contribute in Dawn of Light: code, database *
User avatar
Graveen
Project Leader
 
Posts: 12660
Joined: Fri Oct 19, 2007 9:22 pm
Location: France

Re: [Fix]ABS-UnstyleDamageCap

Postby Centurio » Thu Sep 08, 2011 8:47 am

The formulas are taken from a searching on VN board and other site like (http://talsyra.tripod.com/daocmechanics ... anics.html).
For the 2H bonus, you can also see on DOL, that this formula appears in UnstyleDamageCap, but in AttackDamage the same formula have 20% instead 10%
Heavy metal is The law
User avatar
Centurio
DOL Acolyte
 
Posts: 142
Joined: Tue Feb 13, 2007 10:51 pm
Website: http://www.myspace.com/pagandio

Re: [Fix]ABS-UnstyleDamageCap

Postby Dunnerholl » Thu Sep 08, 2011 1:15 pm

The formulas are taken from a searching on VN board and other site like (http://talsyra.tripod.com/daocmechanics ... anics.html).
For the 2H bonus, you can also see on DOL, that this formula appears in UnstyleDamageCap, but in AttackDamage the same formula have 20% instead 10%
thanks for the clarification! however i dont find the info on absorb. imo absorb is fixed by armor type not quality. quality should affect af and defensive ws
Dunnerholl
Developer
 
Posts: 1229
Joined: Mon Sep 08, 2008 8:39 pm

Re: [Fix]ABS-UnstyleDamageCap

Postby Graveen » Thu Sep 08, 2011 10:15 pm

Centurio can you detail why you added in UnstyledCapDamage() lines such like (what does it target in fact)
Code: Select all
effectiveness += GetModified(eProperty.MeleeDamage) * 0.01;
effectiveness is also not something in the core.

TY mate !
Image
* pm me to contribute in Dawn of Light: code, database *
User avatar
Graveen
Project Leader
 
Posts: 12660
Joined: Fri Oct 19, 2007 9:22 pm
Location: France

Re: [Fix]ABS-UnstyleDamageCap

Postby Centurio » Thu Sep 08, 2011 10:45 pm

UnstyledCapDamage() calculation must follow the line of the AttackDamage() . Into AttackDamage there's a calculation of Bonus toa, like
Code: Select all
effectiveness += GetModified(eProperty.MeleeDamage) * 0.01;
And so i insert that also in UnstyleCap, with the same philosophy
Heavy metal is The law
User avatar
Centurio
DOL Acolyte
 
Posts: 142
Joined: Tue Feb 13, 2007 10:51 pm
Website: http://www.myspace.com/pagandio

Re: [Fix]ABS-UnstyleDamageCap

Postby Graveen » Fri Sep 09, 2011 6:18 am

ok thank you, i see now. i guess i was tired yesterday, you mention it in your first post :)
Image
* pm me to contribute in Dawn of Light: code, database *
User avatar
Graveen
Project Leader
 
Posts: 12660
Joined: Fri Oct 19, 2007 9:22 pm
Location: France

Re: [Fix]ABS-UnstyleDamageCap

Postby Dunnerholl » Fri Sep 09, 2011 6:52 am

absorb source please
Dunnerholl
Developer
 
Posts: 1229
Joined: Mon Sep 08, 2008 8:39 pm

Re: [Fix]ABS-UnstyleDamageCap

Postby Centurio » Fri Sep 09, 2011 10:18 am

I don't remember where i found the documentation about abs :( i'm trying to recover it, but nothing
Heavy metal is The law
User avatar
Centurio
DOL Acolyte
 
Posts: 142
Joined: Tue Feb 13, 2007 10:51 pm
Website: http://www.myspace.com/pagandio

Re: [Fix]ABS-UnstyleDamageCap

Postby Graveen » Fri Sep 09, 2011 12:17 pm

for now i'll ignore the abs part - i want to avoid 'dual shoot' if abs is already processed to modify damages
Image
* pm me to contribute in Dawn of Light: code, database *
User avatar
Graveen
Project Leader
 
Posts: 12660
Joined: Fri Oct 19, 2007 9:22 pm
Location: France

Re: [Fix]ABS-UnstyleDamageCap

Postby Dunnerholl » Fri Sep 09, 2011 1:47 pm

I don't remember where i found the documentation about abs :( i'm trying to recover it, but nothing
u know, there are tons of websites about daoc with wrong formulae, so if something will make it to the core i prefer to know the source. the only thing i found was one saying that abs is used in connection with quality to calc effective af of a piece of armor, but there were no tests or anything.
Dunnerholl
Developer
 
Posts: 1229
Joined: Mon Sep 08, 2008 8:39 pm

Re: [Fix]ABS-UnstyleDamageCap

Postby Tolakram » Fri Sep 09, 2011 2:25 pm

If it's found on VN there's a 99% chance it's completely wrong unless it's also found in a grab bag, which lowers the chance to 50%. If you can find a couple of sources that at least makes it seem plausible then perhaps it can be added as something adjustable with a server property, disabled by default.
- Mark
User avatar
Tolakram
Storm / Storm-D2 Admin
 
Posts: 9189
Joined: Tue Jun 13, 2006 1:49 am
Location: Kentucky, USA

Re: [Fix]ABS-UnstyleDamageCap

Postby Centurio » Fri Sep 09, 2011 3:27 pm

In this weeks i'm working on melee damage formula(on dol there are some imaginative formulas on damage XD ) so i collect much infos on the web and on live..whne i had the possibility, i did some test also on live. Btw, yes it's better do not use ABS changes by now, until i'm figured out where i can take it.Sorry :D
Heavy metal is The law
User avatar
Centurio
DOL Acolyte
 
Posts: 142
Joined: Tue Feb 13, 2007 10:51 pm
Website: http://www.myspace.com/pagandio

Re: [committed] [Fix]ABS-UnstyleDamageCap

Postby Graveen » Mon Sep 12, 2011 1:34 pm

Thank you, accepted, soon in SVN
Image
* pm me to contribute in Dawn of Light: code, database *
User avatar
Graveen
Project Leader
 
Posts: 12660
Joined: Fri Oct 19, 2007 9:22 pm
Location: France


Return to “%s” DOL Code Contributions

Who is online

Users browsing this forum: No registered users and 1 guest