Updated CLWeaponNPC to actually give weapons

[Leodagan]

Here is the patch for the "King" NPC file (it was in there...)

And with it the latest CL Weapon SQL I could make (including needed packageID for the NPC to work...)

The CLWeaponNPC should only give weapon the class can equip to character CL 5 or higher !

Put classtype DOL.GS.CLWeaponNPC to the NPC you'd like to give weapons !

[HunabKu]

Nice works, i think Graveen will tell you to commit

[Graveen]

I like the way you integrated the dynamic proposal of the weapon, related to class AND to availability in the itemtemplate table.

But, what stopped my commit ask is the fact that PACKAGE_ID is a field used only for package management, and should not be used in selection logic (in example, we could affect more than one PACKAGE_ID to an item). Instead we should use not Id_NB (ahah funny me), but an appropriate ClassType.

Thank you Leo !

[Leodagan]

I can change the 'WHERE' condition to look for '%package_string%' this case would be able to handle items with different package_id values... (if someone wanted to use a package_id : 'Champion_Weapons;Darkness_Rising_Pkg;Public DB' it will match...)

Id_nb have no 'matching' string that I could use to select only champion_weapons (in the package I found on forum) maybe with a matching list it could work (WHERE id_nb LIKE 'Dextera%' OR LIKE 'Dochar%' [...])

[Graveen]

Guess you were answering before i update my above post. Proper thing to do is to use ClassType. At first you can simply base the WHERE clause on this field.

I'm not fan of complexifying a WHERE clause (with fuzzy selector such as LIKE, with multiple conditions etc...), because this is something that is not rock solid.

[Leodagan]

So I need a CLWeaponItem class extending ItemTemplate (or an other GameItem class ? I didn't check this part of the code too much ) without adding any properties ?

Or just set a arbitrary classtype in itemtemplate table and gameserver won't use this value as class doesn't exists ?

[Graveen]

Have to think about it a bit, to see when the specific classtype is applyed to ItemTemplate when becoming an InventoryItem. Because when you are proposing something to choose, you have virtually only ItemTemplate.