Spell effect icon fix

[Dinberg]

Hi, this is a long standing bug:

In GameSpellEffect

Code: Select all

public ushort Icon { get { if (m_handler != null && m_handler.Spell != null) return m_handler.Spell.ClientEffect; else return 0; } }

should return m_handler.Spell.Icon, not Spell.ClientEffect.

[Dinberg]

(Or, if you don't like this fix, can we at least have it a virtual ushort so I can override as I please?)

[Graveen]

YW, fixed in ahem, soon, still committing (i realise i had 6 months + commit pending on my computer working copy :p)

[Dinberg]

Did you make it virtual aswell?

[Dinberg]

Could we also have DelveInfo as virtual for GameSpellEffect please? Thanks!

[Graveen]

As you want, but i think you still have commit rights, if you feel easier.

[Dinberg]

I dont think I do! (Didn't last time I checked)

[Graveen]

i would merit to be whipped with fresh stinging neetles if i dared to remove you. I mean, you gained lifetime commit rights !

[Dinberg]

Graveen come on irc, lets chat! I'm in dolserver

[Dinberg]

Also, the void Overwrite in GameSpellEffect could be virtual

[stephenxpimentel]

hmm that explains why I was always annoyed that I couldn't change the icon... explains a lot, just assumed the client wouldn't read it as 2 different #s, glad I was wrong

[doluser]

a stupid question from a noob: where should i place this text?

[Dinberg]

Did this not get added to core? I guess I could raise a pull request