Guild command - Dues Error

[Crazys]

Issue - Old dues breaks from this amount line existing and overriding the 2 value.

Remove Line 2247
client.Player.Guild.SetGuildDuesPercent(amount);

[Leodagan]

Crazys, can you provide the file in which this is found ?

Which 2 values are being overrided ? are they used in different code part ?

[Crazys]

Crazys, can you provide the file in which this is found ?

Which 2 values are being overrided ? are they used in different code part ?

before

Sorry!!! guild.cs (in GameServer/Commands/Player)

Code: Select all

else if (amount > 0 && amount <= 100) { client.Player.Guild.SetGuildDues(true); if (ServerProperties.Properties.NEW_GUILD_DUES) { client.Player.Guild.SetGuildDuesPercent(amount); client.Out.SendMessage(LanguageMgr.GetTranslation(client.Account.Language, "Scripts.Player.Guild.DuesOn", amount), eChatType.CT_Guild, eChatLoc.CL_SystemWindow); } else { client.Player.Guild.SetGuildDuesPercent(2); client.Out.SendMessage(LanguageMgr.GetTranslation(client.Account.Language, "Scripts.Player.Guild.DuesOn", 2), eChatType.CT_Guild, eChatLoc.CL_SystemWindow); } client.Player.Guild.SetGuildDuesPercent(amount); }

After

Code: Select all

else if (amount > 0 && amount <= 100) { client.Player.Guild.SetGuildDues(true); if (ServerProperties.Properties.NEW_GUILD_DUES) { client.Player.Guild.SetGuildDuesPercent(amount); client.Out.SendMessage(LanguageMgr.GetTranslation(client.Account.Language, "Scripts.Player.Guild.DuesOn", amount), eChatType.CT_Guild, eChatLoc.CL_SystemWindow); } else { client.Player.Guild.SetGuildDuesPercent(2); client.Out.SendMessage(LanguageMgr.GetTranslation(client.Account.Language, "Scripts.Player.Guild.DuesOn", 2), eChatType.CT_Guild, eChatLoc.CL_SystemWindow); } }

Just removing the 1 line. Its overriding the else statement if New_Guild_Dues is false.
Not home currently to be able to make a patch.

[Leodagan]

Ok that's clearly an error to me

You should manage some way to enable your Source Forge Account for HTTPS SVN access, I know I had some trouble with it recently, I fallback to SVN+SSH (which is pretty simple if you're a Unix user...) but I haven't tried recently if HTTPS is working again

I can try to commit that quickly.

edit - done : 3367