unicode character support patch

A place to submit .patch fixes for the DOL SVN

Moderator: Developer Team

unicode character support patch

Postby whria78 » Sun Dec 07, 2014 8:45 am

Hi~

Because client blocks unicode character name, I have tried to rename the unicode names to "slota", "slotb", "slotc"....
Untitled-5 copy.jpg
Untitled-5 copy.jpg (222.99 KiB) Viewed 4794 times
It based on SVN 3388. I attached trunk.zip
trunk.zip
(18.19 MiB) Downloaded 52 times
I marks "// WHRIA START" , "//WHRIA END" to all I edited.

If you cannot create unicode character because you use English Windows, create character with numeric number, as like "1234567". Clients & old server does not allow numeric number too.

Because the client saved the character name which was shown in character select windows, there's some problem.
Here is the screenshot. But the server recognize it correctly. As far, there's no problem.
Untitled-2 copy.jpg
Untitled-2 copy.jpg (148.71 KiB) Viewed 4793 times
The server --> "테스트캐릭"
The client --> "slot..."
User avatar
whria78
Contributor
 
Posts: 128
Joined: Fri Sep 21, 2007 11:27 pm

Re: unicode character support patch

Postby Leodagan » Sun Dec 07, 2014 9:09 am

I'm sorry to annoy you about this patch, but another thing bothers me...

Does the "reply" (R button Macro in Client) work with a Latin Client trying to talk to a "Unicode" Player's Character ?

I do think that's why official server wouldn't allow internationalized char names ?

Even if it print garbage in "Latin" Client I do hope macro commands still match on the server, some admins commands concerns me to... ( like /jump to {playerName} )
User avatar
Leodagan
Developer
 
Posts: 1350
Joined: Tue May 01, 2012 9:30 am
Website: https://daoc.freyad.net
Location: Lyon

Re: unicode character support patch

Postby whria78 » Sun Dec 07, 2014 10:29 am

1)
I believe all users should use one kind of patched client.
If all use the unicode-setting client. it may have no problem.
Untitled-1 copy.jpg
Untitled-1 copy.jpg (296.22 KiB) Viewed 4786 times
"휘리아" <--> ununonu

they can chat.

2)
The client supports unicode 2-bytes internally, I guess the reply function works.
In my server, one user reply to my character "휘리아". he cannot type "휘리아", but he can reply by "R" function.

3)
I hope there will be new option (allow_unicode_character_name) in server_property.
User avatar
whria78
Contributor
 
Posts: 128
Joined: Fri Sep 21, 2007 11:27 pm

Re: unicode character support patch

Postby Leodagan » Sun Dec 07, 2014 10:45 am

If you don't mind I'll try to review this patch to prevent any troubles for servers that want to prevent unicode special chars.

Server property is not a hard task ;)
User avatar
Leodagan
Developer
 
Posts: 1350
Joined: Tue May 01, 2012 9:30 am
Website: https://daoc.freyad.net
Location: Lyon

Re: unicode character support patch

Postby whria78 » Sun Dec 07, 2014 12:19 pm

Now I detect what you said.

You said your client crash (Eng locale) & incorrect letters even though you have the font.

I am going to test the client / Eng locale.

I will post it in some time.
User avatar
whria78
Contributor
 
Posts: 128
Joined: Fri Sep 21, 2007 11:27 pm

Re: unicode character support patch

Postby HunabKu » Sun Dec 07, 2014 1:30 pm

I tried to fix that in past but need client modifications to works an that's not allowed by EA !
"C'est l'ignorance qui apporte le chaos, pas la connaissance."
Scarlett Johansson dans "Lucy" de Luc Besson
-------------------------------------------------------------------------------
"Ignorance brings chaos, not knowledge."
Scarlett Johansson on "Lucy" by Luc Besson
User avatar
HunabKu
Developer
 
Posts: 1905
Joined: Sat Jun 18, 2011 4:48 am

Re: unicode character support patch

Postby whria78 » Mon Dec 08, 2014 12:48 am

Application locale changer can solve this problem.

There are severe application locale changer available.

Because game.dll is loaded by loader, in this time , only microsoft applocale works. (It may trace all dll, exe , but others do not)

But I think other locale changer will work with some modification.

I found open source locale changer and tried to make a loader. ^^
User avatar
whria78
Contributor
 
Posts: 128
Joined: Fri Sep 21, 2007 11:27 pm

Re: unicode character support patch

Postby HunabKu » Mon Dec 08, 2014 7:30 am

Nice. Ask me for help if you need.
Please like us informed.
"C'est l'ignorance qui apporte le chaos, pas la connaissance."
Scarlett Johansson dans "Lucy" de Luc Besson
-------------------------------------------------------------------------------
"Ignorance brings chaos, not knowledge."
Scarlett Johansson on "Lucy" by Luc Besson
User avatar
HunabKu
Developer
 
Posts: 1905
Joined: Sat Jun 18, 2011 4:48 am

Re: unicode character support patch

Postby whria78 » Mon Dec 08, 2014 11:39 am

I made a small patch.
kor.zip
(3.89 MiB) Downloaded 53 times
Leodagan. Try to connect to my server with this patch.

edit login.txt and launch whria.exe

ID : testaccount
PASS : 0000
I already made some characters (KOR + JAPAN + RUSSIAN NAME)


Test whether you can chat in your language (French ?)
User avatar
whria78
Contributor
 
Posts: 128
Joined: Fri Sep 21, 2007 11:27 pm

Re: unicode character support patch

Postby Leodagan » Mon Dec 08, 2014 1:28 pm

I don't really like running binary patch :D

what is it doing ?

Is there some config that can be achieved by hand ?
User avatar
Leodagan
Developer
 
Posts: 1350
Joined: Tue May 01, 2012 9:30 am
Website: https://daoc.freyad.net
Location: Lyon

Re: unicode character support patch

Postby whria78 » Mon Dec 08, 2014 3:04 pm

you can use applocale to change your locale.

Download it from microsoft download center and check out the info below.

http://en.wikipedia.org/wiki/AppLocale
http://users.wfu.edu/yipcw/atg/microsoft/applocale/

set locale to 한국어(korean) and launch daoc.bat (batch file to load dolloader)

It changes your application locale temporally.
User avatar
whria78
Contributor
 
Posts: 128
Joined: Fri Sep 21, 2007 11:27 pm

Re: unicode character support patch

Postby whria78 » Tue Dec 09, 2014 10:20 pm

1)
One problem. when two client login simutaneously (dual clients), the quickbar mess because the quickbar information saved as like slota.ini, slob.ini, sloc.ini ....

I change "slota" --> "slota<accountname>"

I attach the source modified.
trunk.zip
(18.18 MiB) Downloaded 49 times
2)
The patch I made is binary launcher to load Microsoft Applocale.

I try to find open source application locale program
User avatar
whria78
Contributor
 
Posts: 128
Joined: Fri Sep 21, 2007 11:27 pm

Re: unicode character support patch

Postby HunabKu » Fri Dec 12, 2014 7:25 am

Nice work !
Thanks, continue :-)
"C'est l'ignorance qui apporte le chaos, pas la connaissance."
Scarlett Johansson dans "Lucy" de Luc Besson
-------------------------------------------------------------------------------
"Ignorance brings chaos, not knowledge."
Scarlett Johansson on "Lucy" by Luc Besson
User avatar
HunabKu
Developer
 
Posts: 1905
Joined: Sat Jun 18, 2011 4:48 am

Re: unicode character support patch

Postby whria78 » Fri Dec 12, 2014 10:03 am

I think the unicode system of darkageofcamelot is rather non-standard.

To use universal language,

# the server locale equal to the client locale
# If not, the client should use application locale changer such as Applocale or ntleas (OPEN SOURCE !!! https://ntlea.codeplex.com/)

I have not tested ntleas, but it would be much helpful , that it is open source.

Im not sure ntleas successfully change the locale of game.dll without modification ( It could change the locale of dolloader.exe , not game.dll )

If DAOCPORTAL support applocale (simple) or include ntleas feature it would be very nice !
User avatar
whria78
Contributor
 
Posts: 128
Joined: Fri Sep 21, 2007 11:27 pm


Return to “%s” DOL Code Contributions

Who is online

Users browsing this forum: No registered users and 1 guest