Style Procs and relation to LineXspell

[Yay]

Hello,

After some research on an errorless error, I found that some style proc spells are missing the LineXspell entry. There is obviously an error message or even an "not implemented" error missing.

CreateMagicEffect in StyleProcessor.cs (beginning at line 621) is the culprite here. To do a conservative fix I would just use

Code: Select all

ISpellHandler spellHandler = ScriptMgr.CreateSpellHandler(caster, styleSpell, styleLine); if (styleSpell == null || (spellHandler == null && caster is GamePlayer)) { .... }

But here is the reason of my post: Is this association even necessary? Because CreateMagicEffect is already only used for style procs and therefore I thought it is sensible to just set the SpellLine to GlobalSpellsLines.Combat_Styles_Effect

It would look like this:

Code: Select all

protected static ISpellHandler CreateMagicEffect(GameLiving caster, GameLiving target, int spellID) { SpellLine styleLine = SkillBase.GetSpellLine(GlobalSpellsLines.Combat_Styles_Effect); Spell styleSpell = SkillBase.GetSpellByID(spellID); if (styleLine == null) return null; ISpellHandler spellHandler = ScriptMgr.CreateSpellHandler(caster, styleSpell, styleLine); if (spellHandler == null && caster is GamePlayer) { ((GamePlayer)caster).Out.SendMessage(styleSpell.Name + " not implemented yet (" + styleSpell.SpellType + ")", eChatType.CT_System, eChatLoc.CL_SystemWindow); } // No negative effects can be applied on a keep door or via attacking a keep door if ((target is GameKeepComponent || target is GameKeepDoor) && spellHandler.HasPositiveEffect == false) { return null; } return spellHandler; }

You can then delete most if not all LineXspell entries with the LineName 'Combat style effects'. It would also make implementing more intuitive and less error prone.

But obviously I maybe oversaw something and therefore I ask if this is sensible to just hardcode the styleLine for procs. (And therefore delete the checks)

Kind regards,

YaY

[HunabKu]

Your research is interesting, i think Leodagan can tell us more.

[Leodagan]

I can't check this from work, but anyway message-less errors is wrong

Even if we may have a lot of Garbage in Log from Warning/Errors that don't break the game we need as much verbosity as we can achieve and ultimately filter message through log4net config...

For the Combat_Styles_Effect there is something wrong in the actual code...

SkillBase Class will mostly never return "null" from a GetSpellLine as this method default to a newly created spell line if it can't be found...

Iterating through hardcoded Line "Combat_Styles_Effect" to match spell ID is also wrong for two reasons :

- It Could be simplified with a LINQ Where() expression
- It won't match spell thats aren't attached to the hardcoded Line in Database...

I remember there is some specific Method in SkillBase, you can look for a Spell ID inside a Specific Line and it will also look for global spell cache to return the spell anyway even if not found in given line (but if spell is found in the given line, spell Level will be set to the Line Required Level...)

Code: Select all

/// <summary> /// Will attempt to find either in the spell line given or in the list of all spells /// </summary> /// <param name="spellID"></param> /// <param name="line"></param> /// <returns></returns> public static Spell FindSpell(int spellID, SpellLine line)

[Yay]

Also there is no error whatsoever. It makes sense, because the output is just no proc and the delve is searching for the proc differently. Finally it's just the condition that leads to the missing error message (not implemented). It would show up otherwise.

But the question is, does it even make sense to search in the spellLine? I mean the spell is already selected by stylexspell and therefore ofc a combat_style_effect and furthermore there is currently no way of using a spell in another line than this line, if I understand this correctly.

Btw the hardcoded version (the second) is working, because I just hardcoded it to combat_style_effects line when casting the spell.

[Leodagan]

I don't really know all the effects of this kind of Hardcoded Line...

I can just tell that matching spell outside of its spell line will create a Level 1 Spell instead of its line level...

Maybe there are other checks around Style Spell to raise the effectiveness to the Level of the user or the Style Level or anything else, but I can't remember

Anyway we should try to make procs work most of the time even if there is some relation missing in hardcoded lines