(Live) Patch #630 - Pet command and AI changes

[Tolakram]

Storm does not work with any client version past 1.109. You can download the 1.109 DLL here -> http://www.mediafire.com/?763i3ia6j4y3yot

Changes from Tolakram:

- Changed: I re-worked some of the controlled NPC commands to work logically, but I'm not 100% sure it is live like. There was code that prevented a pet from casting defensive spells when told to stay at a location. I removed this because it makes no sense to me. I also changed how a pet will check for spells based on aggression. If a pet is put in aggressive mode it will check for attack and offensive spells first. If no target is in range then the pet will check for defensive spells.

There were no comments in the code related to live like behavior. If any of these changes are inappropriate please let me know and I'll revert the modifications.

Changed code: http://sourceforge.net/p/dolserver/code ... 1f24a:3191

[Tolakram]

Thanks to help from Etaew and friend it looks like this is a good change, but still not enough.

so my friend used her healing pet on enchanter to test this for me
reports that the pet stops melee, and heals the caster even when in aggressive mode

Sounds like what we are missing is a way to differentiate if a pet is attacking vs being attacked. If just attacking but not being attacked heals should still be checked, but if under attack it is assumed the AI is smart enough not to try and heal.

[svartson]

I can confirm this behaviour on enchanter.

[Tolakram]

Thanks.

[Etaew]

Sounds like what we are missing is a way to differentiate if a pet is attacking vs being attacked. If just attacking but not being attacked heals should still be checked, but if under attack it is assumed the AI is smart enough not to try and heal.

GameLiving.LastAttackedByEnemyTick

This stores when the living was lacked attacked by an enemy.

The InCombat check is

Code: Select all

public virtual bool InCombatPvE { get { Region region = CurrentRegion; if (region == null) return false; if (LastCombatTickPvE == 0) return false; //if (LastCombatTickPvE + 10000 - region.Time > 0 && this is GameNPC && (this as GameNPC).Brain is IControlledBrain) // log.Debug(Name + " in combat " + (LastCombatTickPvE + 10000 - region.Time)); return LastCombatTickPvE + 10000 >= region.Time; } }

So we can have a new property for

IsUnderAttack which is

Code: Select all

public virtual bool IsUnderAttack { get { Region region = CurrentRegion; if (region == null) return false; if (LastAttackedByEnemyTick == 0) return false; return LastAttackedByEnemyTick + 3000 >= region.Time; } }

I chose + 3000 because 3 seconds seems like a good number... weapon swing or cast speed?

Code not tested, but could give you an idea of a property you could call in the AI.