SVN Revision 3076
PostPosted: Tue May 08, 2012 7:36 pm
by DOLBot
Commit from tolakram
Log Messages
- Bugfix: Do not assume item moved from Mythical slot is a GameMythirian
Files Changed:
MODIFY - DOLSharp/trunk/GameServer/gameobjects/GamePlayer.cs
View Changes:
http://dolserver.svn.sourceforge.net/do ... v&rev=3076
Re: SVN Revision 3076
PostPosted: Tue May 08, 2012 10:13 pm
by Tolakram
Hey matt,
GameInventoryObject OnEquipped is called on each equip. Rather than having a custom check and call for Game Myth... how about just overriding onequipped and letting it handle it. You can't equip a Mythical in any other slot anyway.
Re: SVN Revision 3076
PostPosted: Wed May 09, 2012 2:03 pm
by Tolakram
I'm going to withdraw this request. I think the issue here is that to really work correctly we have to move all the equip code into GameInventoryItems and I'm not willing to commit to that change.
Re: SVN Revision 3076
PostPosted: Thu May 10, 2012 1:33 am
by mattress
Good call on the if GameMythirian, didn't occur to me to use that. Took me a bit to understand where the onequip and onunequips are called, I added some log.warn statements to the GameInventoryItem OnUnEquip and did the same in GamePlayer, I'm not sure when, if ever, the OnUnEquip is used from the GameInventoryItem class, GamePlayer logged my message, the other did not. I'm not sure when/if CheckValid is ever called, which explains why I never could get it working to check for Champ levels when I started tinkering with Mythirians.