Necro Pets still bugged *SOLVED*

[seveatha]

Greetings to everyone that has made this project so strong from when it first started. I have an issue with the Necromancer pets and i am having a very difficult time trying to figure it out. every time i cast my pet, and it does this with all pets it gives me a error as follows, (using the Abomination for example)

12:13:25,461 - [RegionTime4] - WARN - DOL.GS.GameNpcInventoryTemplate - Failed loading NPC inventory template: abomination_fiery_sword

from what i have learned it seems to be an issue where the template for the Abomination's equipment is missing but i still have yet to figure out how to fix the issue. any help in directing me in the proper path can help so i can fix it without having to *steal* anyone's database.

[Tolakram]

That may be an outdated db.

On Storm the EquipmentTemplateID is set to simple model numbers and positions rather than using an entry in npcequipment.

In the table NpcTemplate

For all necro pets except abonimation the EquipTemplateID is set to 10:0. For abomination it's 12:3464

3464 is a weapon model and 12 is the TwoHanded position.

[seveatha]

Thanks for the replay Tolakram.
the issue still remains with the number set 12:3464
I actually changed the numbers from 12:3464 to 12:7 but the issue still remains
the item model for 3464 looks something like a bone commander's staff from midguard if im not mistaken

[Tolakram]

I don't understand where abomination_fiery_sword comes from. Are you using the latest DOL version and database?


Here is our npctemplate entry

REPLACE INTO `npctemplate` (`NpcTemplate_ID`, `TemplateId`, `Name`, `GuildName`, `Model`, `Size`, `MaxSpeed`, `EquipmentTemplateID`, `Flags`, `MeleeDamageType`, `ParryChance`, `EvadeChance`, `BlockChance`, `LeftHandSwingChance`, `Spells`, `Styles`, `Strength`, `Constitution`, `Dexterity`, `Quickness`, `Intelligence`, `Piety`, `Charisma`, `Empathy`, `Abilities`, `AggroLevel`, `AggroRange`, `ClassType`, `Level`, `Race`, `BodyType`, `MaxDistance`, `TetherRange`, `PackageID`, `VisibleWeaponSlots`, `ReplaceMobValues`, `ItemsListTemplateID`, `TranslationId`, `Suffix`, `ExamineArticle`, `MessageArticle`, `Gender`) VALUES ('necro_pet_lvl_45', 206, 'abomination', '', '653', '50', 200, '12:3464', 0, 2, 20, 0, 0, 0, '', '101|1;102|1;103|1;104|1;105|1;106|1;107|1;108|1;109|1;110|1;111|1;112|1;113|1;114|1', 30, 30, 30, 30, 0, 0, 0, 0, '', 80, 500, '', '45', NULL, NULL, 1500, NULL, 'DOL837-NEC', 0, NULL, NULL, NULL, NULL, NULL, NULL, NULL);


These are all I can find for npcequipment.

REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('necromancer_arms', 'necromancer', 28, 141, 0, 0, 0, NULL, NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('necromancer_cloak', 'necromancer', 26, 676, 0, 0, 0, NULL, NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('necromancer_feet', 'necromancer', 23, 143, 0, 0, 0, NULL, NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('necromancer_hands', 'necromancer', 22, 142, 0, 0, 0, NULL, NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('necromancer_legs', 'necromancer', 27, 140, 0, 0, 0, NULL, NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('necromancer_torso', 'necromancer', 25, 1266, 0, 0, 0, NULL, NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('necromancer_weapon', 'necromancer', 12, 3268, 0, 0, 0, NULL, NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('necroservant_shield', 'necroservant', 11, 2201, 22, 0, NULL, 'DOL837-NEC', NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('necroservant_sword', 'necroservant', 10, 2195, 22, 0, NULL, 'DOL837-NEC', NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('greater_necroservant1', 'greater_necroservant', 10, 3476, 0, 103, 0, 'Necro', NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('greater_necroservant2', 'greater_necroservant', 11, 3476, 0, 103, 0, 'Necro', NULL);

[Tolakram]

Here are the spell entries for the necro, which point to the npc template ID's used above.

REPLACE INTO `spell` (`Spell_ID`, `SpellID`, `ClientEffect`, `Icon`, `Name`, `Description`, `Target`, `Range`, `Power`, `CastTime`, `Damage`, `DamageType`, `Type`, `Duration`, `Frequency`, `Pulse`, `PulsePower`, `Radius`, `RecastDelay`, `ResurrectHealth`, `ResurrectMana`, `Value`, `Concentration`, `LifeDrainReturn`, `AmnesiaChance`, `Message1`, `Message2`, `Message3`, `Message4`, `InstrumentRequirement`, `SpellGroup`, `EffectGroup`, `SubSpellID`, `MoveCast`, `Uninterruptible`, `IsPrimary`, `IsSecondary`, `AllowBolt`, `SharedTimerGroup`, `PackageID`, `IsFocus`) VALUES ('321b306b-379a-42d0-be76-f861c18ea548', 9406, 9406, 9406, 'Call Greater Necroservant', 'Caster transforms into a shade, and summons a minion to act through.', 'Self', 0, -10, 10, -88, 0, 'SummonNecroPet', 65535, 0, 0, 0, 0, 0, 0, 0, 45, 0, 205, 0, '', '', '', '', 0, 0, 0, 0, NULL, NULL, NULL, NULL, NULL, 0, 'Necromancer', NULL);
REPLACE INTO `spell` (`Spell_ID`, `SpellID`, `ClientEffect`, `Icon`, `Name`, `Description`, `Target`, `Range`, `Power`, `CastTime`, `Damage`, `DamageType`, `Type`, `Duration`, `Frequency`, `Pulse`, `PulsePower`, `Radius`, `RecastDelay`, `ResurrectHealth`, `ResurrectMana`, `Value`, `Concentration`, `LifeDrainReturn`, `AmnesiaChance`, `Message1`, `Message2`, `Message3`, `Message4`, `InstrumentRequirement`, `SpellGroup`, `EffectGroup`, `SubSpellID`, `MoveCast`, `Uninterruptible`, `IsPrimary`, `IsSecondary`, `AllowBolt`, `SharedTimerGroup`, `PackageID`, `IsFocus`) VALUES ('6b174b3b-5ebf-4756-b46b-448e8cd2714d', 9405, 9405, 9405, 'Call Necroservant', 'Caster transforms into a shade, and summons a minion to act through.', 'Self', 0, -10, 10, -88, 0, 'SummonNecroPet', 65535, 0, 0, 0, 0, 0, 0, 0, 45, 0, 204, 0, '', '', '', '', 0, 0, 0, 0, NULL, NULL, NULL, NULL, NULL, 0, 'Necromancer', NULL);
REPLACE INTO `spell` (`Spell_ID`, `SpellID`, `ClientEffect`, `Icon`, `Name`, `Description`, `Target`, `Range`, `Power`, `CastTime`, `Damage`, `DamageType`, `Type`, `Duration`, `Frequency`, `Pulse`, `PulsePower`, `Radius`, `RecastDelay`, `ResurrectHealth`, `ResurrectMana`, `Value`, `Concentration`, `LifeDrainReturn`, `AmnesiaChance`, `Message1`, `Message2`, `Message3`, `Message4`, `InstrumentRequirement`, `SpellGroup`, `EffectGroup`, `SubSpellID`, `MoveCast`, `Uninterruptible`, `IsPrimary`, `IsSecondary`, `AllowBolt`, `SharedTimerGroup`, `PackageID`, `IsFocus`) VALUES ('6ce5d724-0f57-4bd5-9c14-6bc15c5ab1d8', 9402, 9402, 9402, 'Call Lesser Zombie Servant', 'Caster transforms into a shade, and summons a minion to act through.', 'Self', 0, -10, 10, -88, 0, 'SummonNecroPet', 65535, 0, 0, 0, 0, 0, 0, 0, 45, 0, 201, 0, '', '', '', '', 0, 0, 0, 0, NULL, NULL, NULL, NULL, NULL, 0, 'Necromancer', NULL);
REPLACE INTO `spell` (`Spell_ID`, `SpellID`, `ClientEffect`, `Icon`, `Name`, `Description`, `Target`, `Range`, `Power`, `CastTime`, `Damage`, `DamageType`, `Type`, `Duration`, `Frequency`, `Pulse`, `PulsePower`, `Radius`, `RecastDelay`, `ResurrectHealth`, `ResurrectMana`, `Value`, `Concentration`, `LifeDrainReturn`, `AmnesiaChance`, `Message1`, `Message2`, `Message3`, `Message4`, `InstrumentRequirement`, `SpellGroup`, `EffectGroup`, `SubSpellID`, `MoveCast`, `Uninterruptible`, `IsPrimary`, `IsSecondary`, `AllowBolt`, `SharedTimerGroup`, `PackageID`, `IsFocus`) VALUES ('6f7b3009-e5bb-468b-8b0d-573727cb5cae', 9401, 9401, 9401, 'Call Minor Zombie Servant', 'Caster transforms into a shade, and summons a minion to act through.', 'Self', 0, -10, 10, -88, 0, 'SummonNecroPet', 65535, 0, 0, 0, 0, 0, 0, 0, 2, 0, 200, 0, '', '', '', '', 0, 0, 0, 0, NULL, NULL, NULL, NULL, NULL, 0, 'Necromancer', NULL);
REPLACE INTO `spell` (`Spell_ID`, `SpellID`, `ClientEffect`, `Icon`, `Name`, `Description`, `Target`, `Range`, `Power`, `CastTime`, `Damage`, `DamageType`, `Type`, `Duration`, `Frequency`, `Pulse`, `PulsePower`, `Radius`, `RecastDelay`, `ResurrectHealth`, `ResurrectMana`, `Value`, `Concentration`, `LifeDrainReturn`, `AmnesiaChance`, `Message1`, `Message2`, `Message3`, `Message4`, `InstrumentRequirement`, `SpellGroup`, `EffectGroup`, `SubSpellID`, `MoveCast`, `Uninterruptible`, `IsPrimary`, `IsSecondary`, `AllowBolt`, `SharedTimerGroup`, `PackageID`, `IsFocus`) VALUES ('889b307d-3167-4d2e-8ce4-9b395d24f699', 9407, 9407, 9407, 'Call Abomination', 'Caster transforms into a shade, and summons a minion to act through.', 'Self', 0, -10, 10, -88, 0, 'SummonNecroPet', 65535, 0, 0, 0, 0, 0, 0, 0, 45, 0, 206, 0, '', '', '', '', 0, 0, 0, 0, NULL, NULL, NULL, NULL, NULL, 0, 'Necromancer', NULL);
REPLACE INTO `spell` (`Spell_ID`, `SpellID`, `ClientEffect`, `Icon`, `Name`, `Description`, `Target`, `Range`, `Power`, `CastTime`, `Damage`, `DamageType`, `Type`, `Duration`, `Frequency`, `Pulse`, `PulsePower`, `Radius`, `RecastDelay`, `ResurrectHealth`, `ResurrectMana`, `Value`, `Concentration`, `LifeDrainReturn`, `AmnesiaChance`, `Message1`, `Message2`, `Message3`, `Message4`, `InstrumentRequirement`, `SpellGroup`, `EffectGroup`, `SubSpellID`, `MoveCast`, `Uninterruptible`, `IsPrimary`, `IsSecondary`, `AllowBolt`, `SharedTimerGroup`, `PackageID`, `IsFocus`) VALUES ('deab62fe-0c36-4e7c-8545-df1c45a0eeb8', 9404, 9404, 9404, 'Call Reanimated Servant', 'Caster transforms into a shade, and summons a minion to act through.', 'Self', 0, -10, 10, -88, 0, 'SummonNecroPet', 65535, 0, 0, 0, 0, 0, 0, 0, 45, 0, 203, 0, '', '', '', '', 0, 0, 0, 0, NULL, NULL, NULL, NULL, NULL, 0, 'Necromancer', NULL);
REPLACE INTO `spell` (`Spell_ID`, `SpellID`, `ClientEffect`, `Icon`, `Name`, `Description`, `Target`, `Range`, `Power`, `CastTime`, `Damage`, `DamageType`, `Type`, `Duration`, `Frequency`, `Pulse`, `PulsePower`, `Radius`, `RecastDelay`, `ResurrectHealth`, `ResurrectMana`, `Value`, `Concentration`, `LifeDrainReturn`, `AmnesiaChance`, `Message1`, `Message2`, `Message3`, `Message4`, `InstrumentRequirement`, `SpellGroup`, `EffectGroup`, `SubSpellID`, `MoveCast`, `Uninterruptible`, `IsPrimary`, `IsSecondary`, `AllowBolt`, `SharedTimerGroup`, `PackageID`, `IsFocus`) VALUES ('e126f991-7433-45c7-aa58-05b2b883fda5', 9403, 9403, 9403, 'Call Zombie Servant', 'Caster transforms into a shade, and summons a minion to act through.', 'Self', 0, -10, 10, -88, 0, 'SummonNecroPet', 65535, 0, 0, 0, 0, 0, 0, 0, 45, 0, 202, 0, '', '', '', '', 0, 0, 0, 0, NULL, NULL, NULL, NULL, NULL, 0, 'Necromancer', NULL);

[Tolakram]

Be aware that if you are using a modified DB the above may not work, may replace things you need, and/or make spells unusable. You will need to know what you are doing.

[seveatha]

from what i can tell i am using the server version 1.9.6.r3061

[Tolakram]

Nevermind, it's fricking HARD CODED because the necromancer code is complete and total shit.

Let the following block of code be a prime example of how never to do anything.

Code: Select all

switch (Name) { case "lesser zombie servant": case "zombie servant": EffectList.Add(new MezzRootImmunityEffect()); LoadEquipmentTemplate("barehand_weapon"); InventoryItem item; if (Inventory != null && (item = Inventory.GetItem(eInventorySlot.RightHandWeapon)) != null) item.ProcSpellID = (int)Procs.Stun; break; case "reanimated servant" : LoadEquipmentTemplate("reanimated_servant"); break; case "necroservant": LoadEquipmentTemplate("necroservant"); break; case "greater necroservant": LoadEquipmentTemplate("barehand_weapon"); if (Inventory != null && (item = Inventory.GetItem(eInventorySlot.RightHandWeapon)) != null) item.ProcSpellID = (int)Procs.Poison; break; case "abomination": LoadEquipmentTemplate("abomination_fiery_sword"); break; default: LoadEquipmentTemplate("barehand_weapon"); break; } }

So obviously it's looking for the hard coded LoadEquipmentTemplate("abomination_fiery_sword"); which does not exist.

This is where I say ... screw necros.

Fortunately all necro DB entries have some obscure package id, so here is what we have in npcequipment that should fix the issue.

REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('abomination_fiery_sword', 'abomination_fiery_sword', 12, 7, 73, 7, NULL, 'DOL837-NEC', NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('abomination_flaming_mace', 'abomination_flaming_mace', 12, 842, 73, 35, NULL, 'DOL837-NEC', NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('abomination_frozen_mace', 'abomination_frozen_mace', 12, 842, 73, 42, NULL, 'DOL837-NEC', NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('abomination_poisonous_sword', 'abomination_poisonous_sword', 12, 7, 73, 75, NULL, 'DOL837-NEC', NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('abomination_venomous_mace', 'abomination_venomous_mace', 12, 842, 73, 52, NULL, 'DOL837-NEC', NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('necroservant_shield', 'necroservant', 11, 2201, 22, 0, NULL, 'DOL837-NEC', NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('necroservant_sword', 'necroservant', 10, 2195, 22, 0, NULL, 'DOL837-NEC', NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('reanimated_servant_gladius', 'reanimated_servant', 10, 30, 0, 0, NULL, 'DOL837-NEC', NULL);
REPLACE INTO `npcequipment` (`NPCEquipment_ID`, `TemplateID`, `Slot`, `Model`, `Color`, `Effect`, `Extension`, `PackageID`, `Emblem`) VALUES ('renanimated_servant_shield', 'reanimated_servant', 11, 1077, 0, 0, NULL, 'DOL837-NEC', NULL);

[seveatha]

haha. thanks Tolakram. i guess its just a bad coding but it will get right eventually

[Leodagan]

To add some details to Tolakram reply :

Be really careful of the Name of Necromancer Pet in NPCTemplate Table...

As you can see, in the code chunk provided, the switch statement use the NPC Name, and doesn't use a case insensitive comparison !

If your Necro pets are "Abomination" instead of "abomination" nothing will work !

if you want to update the code to make it case insensitive you can simply edit :

Code: Select all

switch (Name)

to

Code: Select all

switch (Name.ToLower())

Honestly I tried to rewrite all these garbage necro code using subclass for every Pet Abilities but I'm still experiencing a lot of trouble around brain behavior

[Graveen]

Guys i wasn 't aware the necro was THIS crap ! (/summon Tola :p)

[rdsandersjr]

i can see Tola /ignoring this thread from here on out! =)