Slow Spellhander

[dargon]

http://darkageofcamelot.com/content/112 ... atch-notes

This spellhandler is not perfect. While it cannot be broken via combat, and has no immunity, it still interrupts. I welcome anyone to help me fix the interrupt problem, though i will continue to figure it out on my own.

A new crowd control effect referred to as ‘Slow’ is introduced:

Targets affected by Slow have their movement speed reduced, both in and out of combat.
Slow effects do not have an associated immunity timer after the effect ends. A target can be continuously slowed.
Slow stacks on top of any root or snare effect currently on the target - in a sense strengthening the power of the current root or snare.
Slows do not break on damage and do not have an associated immunity timer after its effect ends.
The strength of the slow lasts its full duration. It does not weaken as the remaining duration lowers.
Targets that are root or snare immune can still be slowed.
Slow effects do not interrupt on their own.

[HunabKu]

Nice !

[PlanarChaosRvrtwo]

Well there diffrent methods to fix it write a new spellhandler for that spell that ignore damage or you could make it pulsing spell that tick all 0,1 seconds so is effectivly allways online but that would be an dirty fix.

[dargon]

@PlanarChaosRvrtwo It works perfectly as far as not breaking on damage, but the only issue with this script still is that it shouldn't interrupt the player that it is affecting. Though currently not a major issue, I do hope to figure it out, as I would like to try to make live-like updates to as many classes as I can, and this will be a feature that will be required in that step.

[PlanarChaosRvrtwo]

Whooops missunderstood it^^

Well i guess the problem is then how the effect is added to player then..

[dargon]

indeed. I plan to look around, I'm pretty sure speed warp doesn't interrupt Maybe I can get some leads there haha

[PlanarChaosRvrtwo]

What about dont use spell handlers and let speed warp nodes changing the region ability (if you get what i mean) around itself that force an speed of xy and also throw a NULL spell on the players with delve text for players to let em know what happen.

Cause infact players cant see diffrence!!

That for speed warp^^

And to the new snare effect you recognized to put disease and root together to get the result you want?

[Batlas]

Maybe I misunderstand the issue here, but wouldn't the simplest solution to the matter be to create a flag on the spell to check whether or not the spell interrupts the user and set said flag to false for this situation? Obviously would require some changes to the casting code, but it would solve this issue relatively quickly.

[PlanarChaosRvrtwo]

Interruption only check on casting if caster is interrupted not the spell duration those stuff is located in spellhandler.
That is why you should look into em.

[Batlas]

I'm not the OP, but my point to spells not being able to interrupt players like slow as per Dargons post was a pretty simple solution.


Inside spellhandler you have a flag, let's call it canInterupt for sake of the argument. You set this flag to false for slow.

Then inside gameliving

go to :

public virtual void StartInterruptTimer(int duration, AttackData.eAttackType attackType, GameLiving attacker)

and add something like if(attackType.AttackType == "Spell" && !attackType.SpellHandler.canInterrupt){
InterruptTime = 0;
InterruptAction = 0;
return;
}

This way regardless of what the spell does, it won't interrupt the target. Would probably need to be tweaked to work properly, but the general idea is pretty straight forward. Though admittedly, I have no idea whether or not debuffs/slows should or shouldn't rupt a caster. It's been a while since I've really played one.

[ontheDOL]

thanks dargon for the handler.
I havent actually tried, but i think for the interrupt problem, i believe it is called in the "OnEffectStart" method. You call the "base" method of UnbreakableSpeedDecreaseSpellHandler which has a calls the interrupt check

Code: Select all

effect.Owner.StartInterruptTimer(effect.Owner.SpellInterruptDuration, AttackData.eAttackType.Spell, Caster);

you could get rid of the base call and just add all the logic from the derived classes and leave out this line for the interrupt check (there is also logic in Spellhandler.cs from this same method so include that too)

[Batlas]

ontheDOL,

Thanks, that made me look a bit deeper into the core. I originally, and incorrectly, assumed that all attacks came through the makeattack function in gameliving, which fires the interrupt timer as the last call of the method. Upon further research, your way is the correct way to implement the interrupt fix.

Thanks,

Batlas

[dargon]

im going to take a look now, thanks everyone for your help!

[dargon]

ontheDOL was right on the money! the spell seems to be working as intended now, and original post has been updated with the updated handler! thanks everyone for your help and support, those who gave suggestions to the issues are thanked in the comments for everyone to know the support!