SVN Revision 3076

View and discuss the latests SVN commits, to ensure the best efficiency in our work.

Moderators: Support Team, Developer Team

SVN Revision 3076

Postby DOLBot » Tue May 08, 2012 7:36 pm

Commit from tolakram

Log Messages
- Bugfix: Do not assume item moved from Mythical slot is a GameMythirian

Files Changed:
MODIFY - DOLSharp/trunk/GameServer/gameobjects/GamePlayer.cs

View Changes:
http://dolserver.svn.sourceforge.net/do ... v&rev=3076
User avatar
DOLBot
DOL Bot
 
Posts: 52
Joined: Sat Jan 08, 2011 1:23 pm

Re: SVN Revision 3076

Postby Tolakram » Tue May 08, 2012 10:13 pm

Hey matt,

GameInventoryObject OnEquipped is called on each equip. Rather than having a custom check and call for Game Myth... how about just overriding onequipped and letting it handle it. You can't equip a Mythical in any other slot anyway.
- Mark
User avatar
Tolakram
Storm / Storm-D2 Admin
 
Posts: 8832
Joined: Tue Jun 13, 2006 1:49 am
Location: Kentucky, USA

Re: SVN Revision 3076

Postby Tolakram » Wed May 09, 2012 2:03 pm

I'm going to withdraw this request. I think the issue here is that to really work correctly we have to move all the equip code into GameInventoryItems and I'm not willing to commit to that change.
- Mark
User avatar
Tolakram
Storm / Storm-D2 Admin
 
Posts: 8832
Joined: Tue Jun 13, 2006 1:49 am
Location: Kentucky, USA

Re: SVN Revision 3076

Postby mattress » Thu May 10, 2012 1:33 am

Good call on the if GameMythirian, didn't occur to me to use that. Took me a bit to understand where the onequip and onunequips are called, I added some log.warn statements to the GameInventoryItem OnUnEquip and did the same in GamePlayer, I'm not sure when, if ever, the OnUnEquip is used from the GameInventoryItem class, GamePlayer logged my message, the other did not. I'm not sure when/if CheckValid is ever called, which explains why I never could get it working to check for Champ levels when I started tinkering with Mythirians.
Matt450/Variations of "Matt"
User avatar
mattress
Server Team
 
Posts: 277
Joined: Mon Jul 05, 2010 3:30 am
Location: Oceanside, California


Return to DOL SVN Commits

Who is online

Users browsing this forum: No registered users and 0 guests